Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests over from CLS #31

Open
Qard opened this issue Feb 19, 2015 · 2 comments
Open

Move tests over from CLS #31

Qard opened this issue Feb 19, 2015 · 2 comments

Comments

@Qard
Copy link
Collaborator

Qard commented Feb 19, 2015

Currently, async-listener is somewhat light on tests. Instead, most of the functionality is tested in continuation-local-storage. I feel like many of those tests should probably get migrated to async-listener. In particular: crypto, dns, fs, net, timers and zlib--CLS should not need to concern itself with specific interfaces.
@othiym23
Copy link
Owner

othiym23 commented Mar 7, 2015

True enough, and they're only structured the way they are because CLS came before async-listener. You're working with this stuff more frequently than I am right now -- do you want to take a stab at putting together a PR?

@Qard
Copy link
Collaborator Author

Qard commented Mar 7, 2015

I might look at it a bit tomorrow, if I can get through the Promises issue quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qard @othiym23