Add optional loading indicator (WIP) #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit simpler than Gtk.Spinner, which doesn't seem to actually spin if some code is blocking. Some kind of an async dance would probably be required to make that work as intended. There's a bizarre need for a tiny sleep here for the icon to actually change. It could be that the 1/100 s that is enough on my system might not be enough on someone else's system. Closes #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit simpler than Gtk.Spinner, which doesn't seem to actually spin if some code is blocking. Some kind of an async dance would probably be required to make that work as intended.
There's a bizarre need for a tiny sleep here for the icon to actually change. It could be that the
1/100 s1/10 s that is enough on my system might not be enough on someone else's system.Closes #18