Unable to execute named parameters using '@' in the parameter

[chaixshot]

Version 1.6.0 at same execute fucntion

MySQL.ready(function()
	MySQL.Async.execute('INSERT INTO discord(identifier, discord) VALUES(@identifier, @discord)',
	{
		['@identifier'] = "steam:11000013d8d70d5",
		['@discord'] = "xbl:2535406267274231",
	})
end)

[chaixshot]

[darksaid98]

The column discord in table discord of your database can not be set to NULL, since you haven't enabled it for said column.

Not an oxmysql issue.

[chaixshot]

Look like mysql-async syntax have problem.

[darksaid98]

It should be ['identifier'] = 'test1' not ['@identifier'] = ....

I could have sworn there was backward compatibility for putting '@' in there but I might be wrong, so let me know how that goes.

[chaixshot]

This form 1.5.1 (['@Identifier'] Work)

This form 1.6.0 (['@Identifier'] Not work)

Look like mysql-async syntax compatible not working.
Because this is error on all my old script just update 1.5.1 to 1.6.0
1.6.0 make all mysql function cant send variable to query, because it all have ["@variable"].

MySQL.ready(function()
	local test1 = MySQL.Sync.fetchAll('SELECT id FROM users WHERE identifier = ?',
	{
		"steam:11000010971396e"
	})
	print(test1[1])
	
	---------------------------
	
	local test2 = MySQL.Sync.fetchAll('SELECT id FROM users WHERE identifier = @identifier',
	{
		['@identifier'] = "steam:11000010971396e"
	})
	print(test2[1])
	
	---------------------------

	local test3 = MySQL.Sync.fetchAll('SELECT id FROM users WHERE identifier = @identifier',
	{
		['identifier'] = "steam:11000010971396e"
	})
	print(test3[1])
end)

[darksaid98]

Yea that's what I thought. Seems there's been a regression in backward compatibility in 1.6.

I'm currently digging through the codebase patching another issue. I'll check later to see if this is trivial to re-introduce.

[darksaid98]

This is the same issue as in your first post. Again, the issue is your database setup. You need to allow discord to be set to NULL.

[chaixshot]

Yea that's what I thought. Seems there's been a regression in backward compatibility in 1.6.

I'm currently digging through the codebase patching another issue. I'll check later to see if this is trivial to re-introduce.

Ok, for now i will try this.

local function safeArgs(query, parameters, cb, transaction)
	if type(query) == 'number' then query = Store[query] end
	if transaction then
		assert(type(query) == 'table', ('A table was expected for the transaction, but instead received %s'):format(query))
	else
		assert(type(query) == 'string', ('A string was expected for the query, but instead received %s'):format(query))
	end
	if cb then
		assert(type(cb) == 'function', ('A callback function was expected, but instead received %s'):format(cb))
	end
	local type = parameters and type(parameters)
	if type and type ~= 'table' and type ~= 'function' then
		assert(nil, ('A %s was expected, but instead received %s'):format(cb and 'table' or 'function', parameters))
	end
	
	local nparameters = parameters
	if parameters then
		nparameters = {}
		for name, value in pairs(parameters) do
			nparameters[string.gsub(name, "@", "")] = value
		end
	end
	
	return query, nparameters, cb
end

[thelindat]

Yea that's what I thought. Seems there's been a regression in backward compatibility in 1.6.

I'm currently digging through the codebase patching another issue. I'll check later to see if this is trivial to re-introduce.

Can you confirm that both [':var'] and ['@var'] do not work? I'll have to look back to see what I've changed to break this (likely in the patch for named-parameters).

I'm on New World for now but if you don't find a solution before me then I'll take a look at it.

[chaixshot]

[':var'] and ['@var'] not working both.

[darksaid98]

Fixed in #50.