Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the option for user supplied analysisIds #494

Closed
rtisma opened this issue Oct 31, 2019 · 0 comments
Closed

Remove the option for user supplied analysisIds #494

rtisma opened this issue Oct 31, 2019 · 0 comments
Assignees
Labels
breaking-change Changes to the code might result in breaking-changes SP:5 Issue is estimated at 5 story points

Comments

@rtisma
Copy link
Contributor

rtisma commented Oct 31, 2019

Spec: https://wiki.oicr.on.ca/pages/viewpage.action?pageId=128222479

Random Unique analysisIds will be generated locally, instead of on the federated Id server. This simplifies the interface with the federated id server. Since analysisIds are generated via UUID4, they can be generated locally on song-server side. This means the federated id server will only generate ids for:

  • donor
  • specimen
  • sample
  • file

File ids should also be generated locally, since they are UUID5 hashes of analysisId+fileName, but need to discuss this, as it assumes all fileIds are uuid

  • remove analysis id from payload
  • remove endpoint calling for analysis id
  • update tests for uuid.
@rtisma rtisma added the new-feature Request is a new feature label Oct 31, 2019
@rtisma rtisma added this to the Code Monkeys - Sprint 17 milestone Oct 31, 2019
@rtisma rtisma self-assigned this Oct 31, 2019
@rosibaj rosibaj removed this from the Code Monkeys - Sprint 17 milestone Oct 31, 2019
@rtisma rtisma changed the title Refactor song to use IdService interface Remove the option for user supplied analysisIds Nov 14, 2019
@rosibaj rosibaj added this to the Code Monkeys - Sprint 18 milestone Nov 14, 2019
@rosibaj rosibaj added the SP:5 Issue is estimated at 5 story points label Nov 14, 2019
@rtisma rtisma closed this as completed Nov 26, 2019
@rtisma rtisma added breaking breaking-change Changes to the code might result in breaking-changes and removed breaking new-feature Request is a new feature labels Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes to the code might result in breaking-changes SP:5 Issue is estimated at 5 story points
Projects
None yet
Development

No branches or pull requests

2 participants