Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dcc-common & dcc-id dependency #503

Closed
rtisma opened this issue Nov 13, 2019 · 0 comments
Closed

Remove dcc-common & dcc-id dependency #503

rtisma opened this issue Nov 13, 2019 · 0 comments
Assignees
@KevinFHartmann
Labels
critical This MUST be completed for release maintenance code/dependency maintenance tasks SP:5 Issue is estimated at 5 story points
Milestone
Code Monkeys - Sp...

Comments

@rtisma
Copy link
Contributor

rtisma commented Nov 13, 2019 •
edited by rosibaj
Loading

dcc-id is no longer needed, however when it is removed, several ClassNotFound errors occur at runtime. The errors are related to jaxb and it seems that song-server is dependent on transients of the dcc-id-client dependency. dcc-common is no longer needed in java11 as the usage is minimal and can be replicated in song's utils. This is a cleanup task.

  • Remove the depenency
  • Investigate which transient dependencies are missing after removal and include them
  • Make sure it can build after removal
@rtisma rtisma added the new-feature Request is a new feature label Nov 13, 2019
@rtisma rtisma self-assigned this Nov 13, 2019
@rtisma rtisma mentioned this issue Nov 14, 2019
Merged
@rosibaj rosibaj added maintenance code/dependency maintenance tasks critical This MUST be completed for release SP:5 Issue is estimated at 5 story points and removed new-feature Request is a new feature labels Nov 28, 2019
@rosibaj rosibaj removed this from the Code Monkeys - Sprint 19 milestone Nov 28, 2019
@KevinFHartmann KevinFHartmann self-assigned this Jan 6, 2020
@rosibaj rosibaj closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinFHartmann KevinFHartmann

Labels
critical This MUST be completed for release maintenance code/dependency maintenance tasks SP:5 Issue is estimated at 5 story points
Projects
None yet
Milestone
Code Monkeys - Sprint 20
Development

No branches or pull requests
3 participants
@rtisma @rosibaj @KevinFHartmann