Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References related to collaboratory in docker-compose #851

Open
3 tasks
Azher2Ali opened this issue Aug 22, 2024 · 0 comments
Open
3 tasks

References related to collaboratory in docker-compose #851

Azher2Ali opened this issue Aug 22, 2024 · 0 comments
Assignees

Comments

@Azher2Ali
Copy link
Contributor

Summary of request

The "collaboratory" Spring profile is no longer in use and needs to be removed from the codebase. This includes its removal from the SPRING_PROFILES_ACTIVE environment variable, related comments, and configuration files.

Desired solution

  • Remove the "collaboratory" Profile:

Delete "collaboratory" from the SPRING_PROFILES_ACTIVE environment variable list in the configuration files

  • Clean Up Comments:

Eliminate any comments related to the "collaboratory" profile, such as the one involving the symbolic link to application-collaboratory.yml:
sh #ln -s $SCORE_HOME/conf/application.yml $SCORE_HOME/conf/application-collaboratory.yml && \ # wrapper.app.parameter.5=--spring.profiles.active=collaboratory,prod,secure \

  • Update Configuration Files:

Remove collaboratory.data.directory=${STORAGE_SERVER_DATA_DIR} from the application.properties.template or any other configuration files where it appears.

Additional context

https://github.com/overture-stack/SONG/blob/develop/docker-compose.yml#L54

https://github.com/overture-stack/SONG/blob/develop/docker-compose.yml#L59

https://github.com/overture-stack/SONG/blob/develop/dev/docker-compose.yml#L40

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/Dockerfile#L35

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/Dockerfile#L36

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/Dockerfile#L42

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/config/application.properties.template#L27

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/config/application.properties.template#L39

https://github.com/overture-stack/SONG/blob/develop/song-docker-demo/storage-server/config/application.properties.template#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants