Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FileTypes enum and all references #862

Open
joneubank opened this issue Oct 1, 2024 · 0 comments
Open

Remove FileTypes enum and all references #862

joneubank opened this issue Oct 1, 2024 · 0 comments
Assignees

Comments

@joneubank
Copy link
Contributor

Summary of request

With the implementation of #852 there is no longer a need for the FileTypes enum:
https://github.com/overture-stack/SONG/blob/develop/song-core/src/main/java/bio/overture/song/core/model/enums/FileTypes.java

Details

We want to remove this enum from the code base.

This has a few inconsequential references, in the score-server FileEntity class, and in several Test cases. We can update these references, removing the overloaded function that accepts FileTypes argument, and replacing their use in test case with plain strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants