Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL introspection may not be "disableable" in prod #768

Open
justincorrigible opened this issue Feb 17, 2022 · 0 comments
Open

GraphQL introspection may not be "disableable" in prod #768

justincorrigible opened this issue Feb 17, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@justincorrigible
Copy link
Member

justincorrigible commented Feb 17, 2022

As noticed by @evans-g-crsj, Arranger's GraphQL endpoints seem to expose their schema introspection while on 'production' environments, even though those are meant to be disabled by default.

Doing research into possible causes, I've confirmed the latest of legacy Arranger Server (currently v2.16.2) depends on Apollo package version that should work.
This package claims to do the trick.
However, that package's logic is present in our (outdated) version of Apollo, so it should already be doing this internally but it isn't, which is puzzling.

Speculation: there's an internal dependency conflict, where arranger-server-core (the module that contains the "fix") is being overridden/replaced somehow with a version that doesn't allow disabling introspection.

@justincorrigible justincorrigible self-assigned this Feb 18, 2022
@justincorrigible justincorrigible added the bug Something isn't working label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant