Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor getObjectIdsByAnalysisId to use GET /entities?gnosId= #280

Closed
hlminh2000 opened this issue Oct 2, 2020 · 6 comments
Closed

refactor getObjectIdsByAnalysisId to use GET /entities?gnosId= #280

hlminh2000 opened this issue Oct 2, 2020 · 6 comments
Assignees
Labels
blocker This issue is blocking another new-feature Request is a new feature specs-wip Specs are in progress

Comments

@hlminh2000
Copy link

hlminh2000 commented Oct 2, 2020

To support https://wiki.oicr.on.ca/display/icgcargotech/File+Download+Access+Control.

Refactor 1 function in score-client, to depend on the GET /entities?gnosId= endpoiont and not the GET /studies/{studyId}/analysis/{analysisId}

This is needed for Argo' implementation of access-controlled file download.

Detailed Description

val url = new URL(serverUrl + "/studies/" + programId + "/analysis/" + analysisId + "/files");

@hlminh2000 hlminh2000 added the new-feature Request is a new feature label Oct 2, 2020
@rosibaj rosibaj added the question Further information is requested label Oct 6, 2020
@rtisma
Copy link
Contributor

rtisma commented Oct 7, 2020

After discussing with @rosibaj , we want to go the opposite direction: deprecate the /entities?gnosId usage infavour of the other one. The following ticket outline what needs to be done
#281

Will close this ticket as wont-do

@rtisma rtisma added the wont-do Nope. Just nope. label Oct 7, 2020
@rtisma rtisma closed this as completed Oct 7, 2020
@rosibaj rosibaj reopened this Nov 5, 2020
@rosibaj rosibaj added specs-wip Specs are in progress blocker This issue is blocking another and removed wont-do Nope. Just nope. question Further information is requested labels Nov 5, 2020
@rosibaj rosibaj assigned jaserud and unassigned joneubank and rosibaj Jul 21, 2021
@akachru-github
Copy link

Consider: we tend to use newer versions of Score with legacy versions of Song. This change would support backward compatibility for new Score and older versions of Song.

@jaserud
Copy link
Contributor

jaserud commented Aug 6, 2021

The entiies endpoint in metadata server needs to be able to filter on gnosId. The gateway currently has a bug that prevents this from working with it: icgc-argo/platform-api#457.

@rosibaj
Copy link
Contributor

rosibaj commented Sep 2, 2021

@jaserud can we please get a release for this today?

@jaserud
Copy link
Contributor

jaserud commented Sep 2, 2021

@rosibaj
Copy link
Contributor

rosibaj commented Sep 2, 2021

excellent - thank you @jaserud !

@rosibaj rosibaj closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue is blocking another new-feature Request is a new feature specs-wip Specs are in progress
Projects
None yet
Development

No branches or pull requests

7 participants