Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KF References - Remove directory from score-client/storage/kf #458

Open
4 tasks done
Tracked by #419
Azher2Ali opened this issue Jul 25, 2024 · 2 comments
Open
4 tasks done
Tracked by #419
Assignees

Comments

@Azher2Ali
Copy link
Contributor

Azher2Ali commented Jul 25, 2024

Summary of request

As kf has been completely removed from the codebase, we can delete the entire storage folder as it’s no longer needed. This will not impact any funtionality of the application

Details

@joneubank
Copy link
Contributor

Lets add to this work:
Move the default ScoreStorageService into the same package as the abstract service.
Currently this is at: https://github.com/overture-stack/score/blob/develop/score-client/src/main/java/bio/overture/score/client/storage/score/ScoreStorageService.java
and this can be moved up a level to: https://github.com/overture-stack/score/tree/develop/score-client/src/main/java/bio/overture/score/client/storage

@joneubank
Copy link
Contributor

Lets also remove a config variable used by this KF storage command:

@Value("${kf.download.partSize}")
private int partSize;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants