Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between documentation and code for config discovery #71

Closed
Lebvanih opened this issue Sep 1, 2023 · 2 comments
Closed

Comments

@Lebvanih
Copy link

Lebvanih commented Sep 1, 2023

Hello,

I noticed that in a "recent" commit this line changed from /etc/ovh.conf to /etc/ovh.com https://github.com/ovh/go-ovh/blob/master/ovh/configuration.go#L14. Is this on purpose or just a typo when remaking the code around it?

This comes from the following commit: 39b6ccf

The readme.md still mention /etc/ovh.conf https://github.com/ovh/go-ovh/blob/master/README.md?plain=1#L96

I will adapt our code to use the other name for now, but it would be nice to have this clarified/fixed.

Kr,

@deathiop
Copy link
Contributor

deathiop commented Sep 1, 2023

Hello @Lebvanih ,

This is not intended, don't update your code, I will push a fix ASAP.

@deathiop
Copy link
Contributor

deathiop commented Sep 1, 2023

Fixed in #72.
go get github.com/ovh/[email protected] :)

Thanks for the report!

@deathiop deathiop closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants