move clearInitialNodeNetworkUnavailableCondition to clustermanager #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobTanenbaum
requested review from
trozet,
dcbw,
girishmg and
jcaamano
as code owners
|
@dcbw PTAL |
JacobTanenbaum
force-pushed
the
fixClearInitialCondition
branch
2 times, most recently
from
e5cab88
to
b582cfe
Compare
dcbw
reviewed
Aug 24, 2023
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager Signed-off-by: Jacob Tanenbaum <[email protected]>
JacobTanenbaum
force-pushed
the
fixClearInitialCondition
branch
from
b582cfe
to
87a8c3f
Compare
trozet
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearInitialNodeNetworkUnavailableCondition needs to be run on every node for GCP. Since we have some nodes that are not running ovn-kubernetes, notably windows, it should be run in the clustermanager
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog