Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect app_provider values from capabilities #4075

Closed
michaelstingl opened this issue Jun 15, 2023 · 4 comments · Fixed by #4113
Closed

Respect app_provider values from capabilities #4075

michaelstingl opened this issue Jun 15, 2023 · 4 comments · Fixed by #4113

Comments

@michaelstingl
Copy link
Contributor

@DeepDiver1975 reported in https://github.com/owncloud/enterprise/issues/5747#issuecomment-1593139899, Android app doesn't respect the app_provider values from the capabilities

      "capabilities": {
        "files": {
          "app_providers": [
            {
              "enabled": true,
              "version": "1.1.0",
              "apps_url": "/app/list",
              "open_url": "/app/open",
              "open_web_url": "/app/open-with-web",
              "new_url": "/app/new"
            }
          ]
        }
      }
@DeepDiver1975
Copy link
Member

Specifically: apps_url is not respected in my test. No matter what the server (owncloud 10) is returning as path - android app is still calling /app/list

@jesmrec jesmrec added the p4-low Low priority label Jun 16, 2023
@jesmrec jesmrec added this to the 4.1 - Next milestone Jun 16, 2023
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Jun 26, 2023

Testsystem: https://app-registry-demo.owncloud.works
User demo:123456

@DeepDiver1975
Copy link
Member

curl -u demo:123456 https://app-registry-demo.owncloud.works/ocs/v2.php/cloud/capabilities?format=json | json_pp
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2599  100  2599    0     0  10366      0 --:--:-- --:--:-- --:--:-- 10396
{
   "ocs" : {
      "data" : {
         "capabilities" : {
            "checksums" : {
               "preferredUploadType" : "SHA1",
               "supportedTypes" : [
                  "SHA1"
               ]
            },
            "core" : {
               "pollinterval" : 30000,
               "status" : {
                  "edition" : "Enterprise",
                  "hostname" : "app-registry-demo",
                  "installed" : true,
                  "maintenance" : false,
                  "needsDbUpgrade" : false,
                  "product" : "ownCloud",
                  "productname" : "ownCloud",
                  "version" : "10.13.0.0",
                  "versionstring" : "10.13.0 prealpha"
               },
               "support-url-signing" : true,
               "webdav-root" : "remote.php/webdav"
            },
            "dav" : {
               "chunking" : "1.0",
               "propfind" : {
                  "depth_infinity" : false
               },
               "reports" : [
                  "search-files"
               ],
               "trashbin" : "1.0"
            },
            "files" : {
               "app_providers" : [
                  {
                     "apps_url" : "/index.php/app/list",
                     "enabled" : true,
                     "open_web_url" : "/index.php/app/open-with-web",
                     "version" : "1.1.0"
                  }
               ],
               "bigfilechunking" : true,
               "blacklisted_files" : [
                  ".htaccess"
               ],
               "blacklisted_files_regex" : "\\.(part|filepart)$",
               "favorites" : true,
               "file_locking_enable_file_action" : false,
               "file_locking_support" : true,
               "privateLinks" : true,
               "privateLinksDetailsParam" : true,
               "undelete" : true,
               "versioning" : true
            },
            "files_sharing" : {
               "api_enabled" : true,
               "auto_accept_share" : false,
               "can_share" : true,
               "default_permissions" : 31,
               "federation" : {
                  "incoming" : true,
                  "outgoing" : true
               },
               "group" : {
                  "expire_date" : {
                     "enabled" : false
                  }
               },
               "group_sharing" : false,
               "providers_capabilities" : {
                  "ocFederatedSharing" : {
                     "remote" : [
                        "shareExpiration"
                     ]
                  },
                  "ocinternal" : {
                     "group" : [
                        "shareExpiration"
                     ],
                     "link" : [
                        "shareExpiration",
                        "passwordProtected"
                     ],
                     "user" : [
                        "shareExpiration"
                     ]
                  }
               },
               "public" : {
                  "can_create_public_link" : true,
                  "defaultPublicLinkShareName" : "Public link",
                  "enabled" : true,
                  "expire_date" : {
                     "days" : "7",
                     "enabled" : true,
                     "enforced" : false
                  },
                  "multiple" : true,
                  "password" : {
                     "enforced" : false,
                     "enforced_for" : {
                        "read_only" : false,
                        "read_write" : false,
                        "read_write_delete" : false,
                        "upload_only" : false
                     }
                  },
                  "roles_api" : true,
                  "send_mail" : false,
                  "social_share" : true,
                  "supports_upload_only" : true,
                  "upload" : true
               },
               "remote" : {
                  "expire_date" : {
                     "enabled" : false
                  }
               },
               "resharing" : true,
               "search_min_length" : 3,
               "share_with_group_members_only" : false,
               "share_with_membership_groups_only" : false,
               "user" : {
                  "expire_date" : {
                     "enabled" : false
                  },
                  "profile_picture" : true,
                  "send_mail" : true
               },
               "user_enumeration" : {
                  "enabled" : true,
                  "group_members_only" : false
               }
            },
            "password_policy" : {
               "password_requirements" : {
                  "configuration" : {
                     "lower_case" : {
                        "generate_from" : {
                           "characters" : "abcdefghijklmnopqrstuvwxyz"
                        }
                     },
                     "numbers" : {
                        "generate_from" : {
                           "characters" : "1234567890"
                        }
                     },
                     "special_characters" : {
                        "generate_from" : {
                           "any" : true
                        }
                     },
                     "upper_case" : {
                        "generate_from" : {
                           "characters" : "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
                        }
                     }
                  }
               }
            }
         },
         "version" : {
            "edition" : "Enterprise",
            "major" : 10,
            "micro" : 0,
            "minor" : 13,
            "product" : "ownCloud",
            "string" : "10.13.0 prealpha"
         }
      },
      "meta" : {
         "itemsperpage" : "",
         "message" : "OK",
         "status" : "ok",
         "statuscode" : 200,
         "totalitems" : ""
      }
   }
}

@Aitorbp
Copy link
Collaborator

Aitorbp commented Jul 28, 2023

TASKS

  • Research (if needed)
  • Create branch feature/respect_app_provider_values_from_capabilities
  • Development tasks
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/respect_app_provider_values_from_capabilities into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants