Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Align Sharing icons with other platforms #4101

Closed
9 tasks
michaelstingl opened this issue Jul 14, 2023 · 5 comments · Fixed by #4112
Closed
9 tasks

[FEATURE REQUEST] Align Sharing icons with other platforms #4101

michaelstingl opened this issue Jul 14, 2023 · 5 comments · Fixed by #4112

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Jul 14, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context

CleanShot 2023-07-14 at 10 13 42@2x

TASKS

  • Research (if needed)
  • Create branch feature/align_sharing_icons_with_other_platforms
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/align_sharing_icons_with_other_platforms into master

PR

  • App
  • Library (if needed)
@jesmrec
Copy link
Collaborator

jesmrec commented Jul 14, 2023

In the Android app, both "Share with Users" and "Share by Link" are handled in the same "Share" view which is represented by the current icon. Should we keep this and only change the icon in the list?

@michaelstingl
Copy link
Contributor Author

michaelstingl commented Jul 14, 2023

I'd like to get rid of this icon for ownCloud user / group sharing:

Sharing Icon

It's used on the Android platform to send a copy of a file to another app. For this, it can stay.

Whenever we indicate ownCloud user / group sharing or have an action for ownCloud user / group sharing, I'd like to use the icon with the 2 people, as you can see in web and iOS.

/cc @tbsbdr

@michaelstingl
Copy link
Contributor Author

In the Android app, both "Share with Users" and "Share by Link" are handled in the same "Share" view which is represented by the current icon. Should we keep this and only change the icon in the list?

iOS app uses 2-people icon for the share menu item for user / group + link:

CleanShot 2023-07-14 at 10 57 09@2x

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 14, 2023

Replace in:

  • File list (second info line)
  • Bottom operations sheet
  • Multiselection mode

@michaelstingl
Copy link
Contributor Author

CleanShot 2023-07-17 at 10 26 34@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment