Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Log Files seamlessly within the ownCloud Android App #4156

Closed
dpapac opened this issue Sep 7, 2023 · 4 comments · Fixed by #4215
Closed

Sharing Log Files seamlessly within the ownCloud Android App #4156

dpapac opened this issue Sep 7, 2023 · 4 comments · Fixed by #4215
Assignees
Labels
Milestone

Comments

@dpapac
Copy link

dpapac commented Sep 7, 2023

Actual behaviour

When attempting to share log files with our own application, it does not appear as a selectable option in the sharing menu.

Expected behaviour

Our own application should be listed among the available apps for sharing when trying to share log files.

@dpapac dpapac changed the title Sharing Log Files seamlessly within ownCloud Sharing Log Files seamlessly within ownCloud Android App Sep 7, 2023
@dpapac dpapac changed the title Sharing Log Files seamlessly within ownCloud Android App Sharing Log Files seamlessly within the ownCloud Android App Sep 7, 2023
@michaelstingl
Copy link
Contributor

@dpapac what exact version? Post a screenshot?

@JuancaG05
Copy link
Collaborator

This is a explicit restriction specified in the current code:

// Show dialog, without the own app
val packagesToExclude = arrayOf<String>(this.packageName)

So the best thing to do is create a new brandable parameter (allow_sharing_with_own_app?) which states if we can share with the own app or not, keeping false as default value to keep current behaviour. Just in case there is a historical reason for that restriction to be there.

@michaelstingl
Copy link
Contributor

michaelstingl commented Nov 16, 2023

No problem to show own app from my POV (for everyone)

@michaelstingl michaelstingl added the p3-medium Normal priority label Nov 23, 2023
@jesmrec
Copy link
Collaborator

jesmrec commented Nov 24, 2023

Done. To be released in 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants