Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 11.1.3.1a Info and relationships (headings) #4362

Closed
5 tasks done
Tracked by #4398
tschiebel opened this issue Apr 5, 2024 · 3 comments · Fixed by #4448
Closed
5 tasks done
Tracked by #4398

[a11y] 11.1.3.1a Info and relationships (headings) #4362

tschiebel opened this issue Apr 5, 2024 · 3 comments · Fixed by #4448

Comments

@tschiebel
Copy link

tschiebel commented Apr 5, 2024

audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV

https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf
https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de

Shares

  • There are several visually clearly recognizable headings on the page, but they are not labeled as such. These headings include "Sharing", "Users and groups" and "Public links".

Edit shared link

  • There is a clearly visually recognizable heading on the page "Edit shared link", but it has not been labeled as such.

Spaces

  • There is a clearly visually recognizable heading "Spaces" on the page, but it has not been labeled as such.

Note: The heading "Spaces" also functions as a button, but this is not visually recognizable. It would be better to provide a separate button.

Manage accounts

  • There is a clearly visually recognizable heading "Manage accounts" on the page, which is not labeled as such.

Image Viewer

  • The file name could be labeled as a heading.
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 9, 2024

Need research: how to set text as heading in Android. Don't seem to be something native in the platform.

As posible plan B: add "heading" prefix in alternative text.

  • Translatable strings

@JuancaG05 JuancaG05 added this to the Accessibility milestone May 3, 2024
@JuancaG05
Copy link
Collaborator

Check together with #4363, #4371 and #4373

@Aitorbp Aitorbp self-assigned this Aug 6, 2024
@Aitorbp Aitorbp linked a pull request Aug 7, 2024 that will close this issue
4 tasks
@Aitorbp
Copy link
Collaborator

Aitorbp commented Aug 9, 2024

audit: https://infinite.owncloud.com/s/QtwuiGHikwFjozV

https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de

Shares

  • There are several visually clearly recognizable headings on the page, but they are not
    labeled as such. These headings include "Sharing", "Users
    and groups" and "Public links".

The heading has been included in the element of the Shares: "toolbar" title, "Users and groups" and "Public links".

Edit shared link

  • There is a clearly visually recognizable heading on the page "Edit shared link
    Edit shared link" on the page, but it has not been labeled as such.

The heading has been added to Edit shared link title on the top of the dialog.

Spaces

  • There is a clearly visually recognizable heading "Spaces" on the page, but it has not been
    not labeled as such.

Note: The heading "Spaces" also functions as a button, but this is not visually recognizable. visually recognizable. It would be better to provide a separate button for editing button.

In this case, it is not going to be labeled as a heading, because we consider it to be a specific element within the toolbar and there are a lot of elements in that view. Also, its functionality is not that of a header, but that of a search item. The Search view could be changed to only open by clicking the search view icon, but that is outside the scope of the issue. Therefore, it will not be changed either.

TODO in #4452

Manage accounts

  • There is a clearly visually recognizable heading "Manage accounts" on the page, which
    not labeled as such.

Manage accounts title has been added as a heading.

Image Viewer

  • The file name could be labeled as a heading.

As for the file name of the image viewer, it is not going to be labeled as a heading, because we think it to be a specific item within the toolbar and there are more elements in that view (five exactly). Same logic like the Spaces.

more research in #4448 (comment). Other Google apps do not label such titles as headings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants