Desktop Sharing / Desktop Overlay Icons - show shared by me files

[stonerl]

When a file is shared to me by another user, the file-manager (e.g. Finder on OS X) indicates this by "extending" the overlay with the sharing icon.

But files I shared with other users or by link are not indicated at all (the upper file in the picture). Would it make sense to add such overlay icons?

Furthermore since desktop sharing has been introduced, imho it would be quite handy to have the possibility to see the shares in the desktop client as it can be on the server (Shared with you / Shared with others / Shared by link).

[guruz]

This might actually a server bug..
Which server version do you use? I remember there was something related to "Shared" flag being sent down to client as file permission.

CC @icewind1991 @PVince81

[stonerl]

1.8.0 stable

[guruz]

@stonerl Server, not client :)

[stonerl]

@guruz Sorry :-). 8.0.2

[mihaig11]

I have exactly the same problem with the linux 1.8.0 client and 7.0.5 server.

[danimo]

@guruz This is not a server bug. It's a true limitation. Problem is again how to reflect it on Windows. All other OSes can have those icons easily I think.

[guruz]

@danimo This is about

But files I shared with other users or by link are not indicated at all (the upper file in the picture).

with other vs from other

@icewind1991 @PVince81 Any comment? :)

[ogoffart]

We are showing the icon if the server report a "S" bit in the permission field.
Most likely the server don't report the right sharing state.

[Dianafg76]

I tried the problem in Windows, desktop v 1.8.2 (build 5133 ), Server v{"installed":true,"maintenance":false,"version":"8.1.0.6","versionstring":"8.1 beta 2","edition":"Enterprise"} and passes the same

[dragotin]

Yes, that works as designed: Files that are shared by me are not marked as shares. There have been discussions earlier, but that is the status quo IIRC.

[rullzer]

Now that owncloud/core#22789 is in (and backported to 9.0.1). We could implement this on the client.

Basically ask for the webdav property share-types and you get the info you want.

[guruz]

@rullzer @icewind1991 This means during discovery we always need to ask 1 more property. Which is OK but not nice.
I'm curious, what was the reason for not supplying this info also via S permission?

[rullzer]

Well S was defined to be shared with you as far as I know.
We could extend this to also include yet another letter to indicated shared by the current user. The new property was chosen because it is cleaner. And we can directly indicate how a file was shared. Which is something clients can chose to do.

[dragotin]

duplicate of #4788