deleting a folder should send one delete request for the whole folder to the server if possible

[schiessle]

This issue was reported in the core repository but I think we have to fix this on the client side: owncloud/core#3192

The problem: If you delete a folder "foo" on the desktop the sync client will send a delete request to the server for every single file in the folder. For the server this looks like independent delete operations. This means that the files will appear in the trash bin one by one together with a empty folder "foo" so that the user has no option to restore the folder together with the files.

Would it be possible for the client to send only one delete request for the folder if all files within the folder and the folder itself are deleted on the desktop?

[guruz]

Right now, mirall/csync is operating on a "per file" basis. There is no concept of folders that could be deleted instead of the file. I think @ogoffart was working on changing that, but I'm not sure.

(There is some possible things to think about, like concurrent modifications where we would not want any data loss)..

[schiessle]

@guruz I'm not into mirall/csync so maybe this is a dump idea. But shouldn't it be possible for the sync client to detect that also the parent of a file is gone and than ignore the single files and only send one delete request for the top-level folder to the server.

[schiessle]

@danimo @dragotin Is is really not possible to detect folder delete on the client and send a single delete request to the server? We are getting regular bug reports because of this behaviour.

[guruz]

@ogoffart has some code to do this ("new propagator").

Need to discuss with @dragotin etc at the dev meeting next week on when to start using that..

[etiess]

Hello,
This issue is still there in 1.4.0. And the problem is big if I want to restore the folder: I have to restore all individual files!
Is there a project to solve that?
Thank you!
Etienne

[ogoffart]

Should be fixed with 1.5