Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember changes to sort order #10788

Closed
Bugsbane opened this issue Aug 31, 2014 · 26 comments · Fixed by #23933
Closed

Remember changes to sort order #10788

Bugsbane opened this issue Aug 31, 2014 · 26 comments · Fixed by #23933

Comments

@Bugsbane
Copy link

This is an enhancement request to improve the sort order of files and folders as per the suggestions of @jancborchardt and @onny in the issue at #164 .

Specifically, this includes:

  1. Change from the current default of having file/folder sort order be by name, to being by date, with most recent files listed at the top.
  2. Remembering changes to the sort order by the user, so it's remembered when they come back to that folder later.
@karlitschek
Copy link
Contributor

@PVince81

@PVince81
Copy link
Contributor

I personally wouldn't like having sort by date being the default, considering that regular desktop file managers also sort by name by default.

For remembering changes: need to decide where to save it: cookie/localstorage or app settings in the database. To consider: does a user want to keep the last sorting settings when switching browsers/computers ?

@Bugsbane
Copy link
Author

I guess it comes down to what the most common use case is. Whether people are likely to be wanting to access the files they've most recently used, or whether they're likely to be looking for files used less recently, but that they know the file name of.

For my personal use case, I would want sort order to be persistent across devices, although if it makes a big difference, it's a fairly minor inconvenience to need to change the sort order once per device.

@jancborchardt jancborchardt changed the title Folders default to sort by date and remember changes to sort order Remember changes to sort order Sep 2, 2014
@jancborchardt
Copy link
Member

I cut the description to just »remember sort order«. Otherwise this is 2 issues in one.

And I do agree, the sort order should be remembered. And it should be remembered per-user, meaning it is also the same when switching browsers/computers – of course.

I would even say changing the sort order should be global, meaning when you change it in root, change it in all subfolders as well.

@Bugsbane
Copy link
Author

Bugsbane commented Sep 7, 2014

I don't know about that last point. If I change something in a folder, I expect those changes to be there when I come back (even if on another device). I don't expect it to change a whole bunch of folders I haven't even looked at, unless I've done something to explicitly state that I wanted that.

@oparoz
Copy link
Contributor

oparoz commented Jan 30, 2015

I agree with @Bugsbane, Add a tick box, just like on Windows to let the user apply the changes globally if he wants to, but don't make that the default behaviour.

@MartinW2
Copy link

MartinW2 commented Feb 1, 2015

Sorry, i don't agree with the opinion of jancborchardt to close #13484.

  1. If the user is not logged in, there is no reliable possibility to store his sort order preference. A main advantage of owncloud is the possibility to share links that do NOT need any login.

  2. Especially first-time users or unexperienced users are happy to be presented with a view that already is sorted in reasonable order. Depending on the usecase, an admin can very well decide what is the preferred order. For any kind of collection, where items come in from time to time, it makes sense to have newest items first. I claim this is a main use case of owncloud for private use.

Both (1) and (2) are good reasons to allow the administrator to set a default order, at least to let it be sorted by upload date desc.
So, it's NOT THE SAME as allowing the user to sort himself (which is a nice feature of course, but does not meet the point here).
Please reopen request #13484 or include it in this request. Thank you.

@Bugsbane
Copy link
Author

Bugsbane commented Feb 3, 2015

I would suggest that if the user is not logged in that yes, we can still remember sort order via a cookie and that showing a decent view to new users can be achieved by carefully chosen defaults rather than having admins of every pod go and manually set defaults for their users. Between reasonable defaults in ownCloud and users being able to change them with a single click via an interface paradigm most are used to from file managers, we have the overwhelming majority of use cases covered.

For the defaults, it seems to me that in most (not all, but most) cases, users generally want to be seeing their most recently modified files first.

@MorrisJobke
Copy link
Contributor

@Bugsbane Full ACK

@jancborchardt
Copy link
Member

@Bugsbane did I mention that I like you? ;)

@MartinW2 so yeah, basically what @Bugsbane wrote. This is a setting that should not be set by admins.

@Bugsbane
Copy link
Author

Bugsbane commented Feb 5, 2015

@jancborchardt - Thanks! Gosh, now I feel guilty for repeatedly trying to load the 404 page for owncloud.org/jan-borchardt-is-evil.htm enough that it shows near the top of the site logs yesterday, to confuse the webmaster.

You may think I'm joking. You'd be wrong. I have a strange sense of humor.

Anyway, 90% of what I've learned about user interaction has been from reading your comments on various FOSS projects, so your compliment meaningful to me.

@jancborchardt
Copy link
Member

@Bugsbane LOL

Anyway, 90% of what I've learned about user interaction has been from reading your comments on various FOSS projects, so your compliment meaningful to me.

Thanks, right back at you! :)

@DeepDiver1975 DeepDiver1975 modified the milestone: backlog Mar 21, 2015
@oparoz
Copy link
Contributor

oparoz commented Apr 10, 2015

This feature request has been kind of implemented in Gallery+. The order is not saved when you use the buttons, but you can define defaults for folders and the settings can be inherited.

More information here:
https://github.com/interfasys/galleryplus/blob/master/documentation/Album%20configuration.md

@jancborchardt
Copy link
Member

@oparoz this is about the files app though, and the sort order defined by the table headers.

@oparoz
Copy link
Contributor

oparoz commented Apr 11, 2015

Indeed, but I'm just mentioning the way we do it in another app so that participants in this thread can test an alternative way of doing things to see if it would meet their the needs.

@MartinW2
Copy link

Thanks a lot, @oparoz . As #13484 has been closed, I am happy that someone see the needs of Admins that simply want to make life easier for their occasional or anonymous users by setting optional, reasonable defaults. Of course users should be empowered to dynamically or permanently override sort order as they want - but I don't see why this is in contradiction to admins that (optionally) want to provide their users with a reasonable starting point. It's not the same thing either.
I probably miss the abilities and UI experience of some owncloud power users to know users needs ...
So, thanks again for letting me know via this post.

@jancborchardt jancborchardt modified the milestones: 8.2-current, backlog Jul 20, 2015
@jancborchardt
Copy link
Member

We should fix this for 8.2 – this is very annoying for people who prefer to have their files sorted by modification date as default.

@ghost
Copy link

ghost commented Sep 9, 2015

@DeepDiver1975 looking for an assignment

@jancborchardt
Copy link
Member

Would be a bummer, but I assume this can not be done for 8.2 and hence needs to be moved to 9.0? @DeepDiver1975?

@jancborchardt jancborchardt modified the milestones: 9.0-next, 8.2-current Sep 15, 2015
@PVince81
Copy link
Contributor

We're past feature freeze, moving to 9.1.

Has there been a consensus yet regarding where to store that setting and its scope ?

  • JS variable: cleared on refresh
  • cookie / localStorage: only in the current browser
  • oc_preferences: kept across sessions for the same user

@PVince81 PVince81 modified the milestones: 9.1-next, 9.0-current Feb 18, 2016
@oparoz
Copy link
Contributor

oparoz commented Feb 18, 2016

The last option seems to be the best one and even though it's not part of a public API, it's still something that apps can use.

@Bugsbane
Copy link
Author

Definitely the last option. The other two provide an inconsistent experience for the user over time/devices.

@jancborchardt
Copy link
Member

Yep, definitely the last one. All settings should be user-specific and remembered, not only browser- or session-specific.

@jancborchardt
Copy link
Member

Since we also talked about the »show recent files« during the 9.1 meetings, I would like to propose this for inclusion for 9.1 @cmonteroluque @MTRichards @PVince81

@ghost
Copy link

ghost commented Apr 5, 2016

let's see if it can be done in the bug fixing phase

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants