-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we have a test to ensure utf8 compatability for the files app and webdav? #3190
Comments
pulling @icewind1991 @DeepDiver1975 @Raydiation @bartv2 @karlitschek here for an opinion on how to test utf8 capability of the files app and webdav. |
Ok, let's handle this case by case:
|
@danimo You can get rid of the UTF8 dependency on the filesystem by using randomly generated ASCII/Hex characters as filesystem filenames and putting the original filename into the DB, which surely supports UTF8. This will also get rid of any problems regarding max filename or max pathname length etc. |
@bantu This is sort of what we do on windows, but it has several disadvantages, the most important being that the database may never get lost. |
@danimo Don't you think that is a reasonable assumption? |
the current implementation for windows can be extended to store the mapping of real file/folder names to their physical name in a second storage. e.g. a hidden file within the directories. In case the database is lost we can recreate the names on the initial scan. PRs are welcome ... |
@DeepDiver1975 Yeah no, a hidden file probably won't do it. At least not on a system with many concurrent write accesses. Also poorly scales across multiple servers. Just use the database and implement preriodic SQL dumps instead? |
should not be an issue as this file will write to in case a file is created, deleted or renamed. |
@DeepDiver1975 Kind of how SVN did it (and failed)? What's wrong with with using the DB? It seems to be a DB you are looking for. |
yes
hmm - as long as the files are not accessible by users directly I don't see an issue with that.
Nothing - with the exceptions that database backup strategies are within the responsibility of the system operator. |
Well, you require a DB - so why not use it? |
Maybe I've been not precise enough: The main data storage will be the database. The hidden file is just the fallback. |
@DeepDiver1975 Oh, yeah, that wasn't clear. Must have missed it. Sorry. |
no prob |
Is this still relevant after so many months ? 😄 |
This is still relevant for #10625, and CIFS. I'm not sure about webdav, |
filecache test has been added with #10244 |
Closing due to inactivity |
I had a stange error when the files were stored on an nfs that in the end did not store files as utf8. Everything seemed to work fine but files containing ß. äöü were no Problem.
The acceptence tests use the files from the Demo owncloud. could we add a file with the name
ß äöü ÄÖÜ èéȩ w͢͢͝h͡o͢͡ ̸͢k̵͟n̴͘ǫw̸̛s͘ ̀́w͘͢ḩ̵a҉̡͢t ̧̕h́o̵r͏̵rors̡ ̶͡͠lį̶e͟͟ ̶͝in͢ ͏t̕h̷̡͟e ͟͟d̛a͜r̕͡k̢̨ ͡h̴e͏a̷̢̡rt́͏ ̴̷͠ò̵̶f̸ u̧͘ní̛͜c͢͏o̷͏d̸͢e̡͝ .txt
which becomes 'ß äöü ÄÖÜ èéȩ w͢͢͝h͡o͢͡ ̸͢k̵͟n̴͘ǫw̸̛s͘ ̀́w͘͢ḩ̵a҉̡͢t ̧̕h́o̵r͏̵rors̡ ̶͡͠lį̶e͟͟ ̶͝in͢ ͏t̕h̷̡͟e ͟͟d̛a͜r̕͡k̢̨ ͡h̴e͏a̷̢̡rt́͏ ̴̷͠ò̵̶f̸ u̧͘ní̛͜c͢͏o̷͏d̸͢e̡͝ .txt' containing the name as a string as well?Where would we put a PHP-Unit test for this? files?
@danimo explained to me that the client always sends NFC. How do we deal with filenames entered in the ui as NFD? Can this happen?
Links:
http://en.wikipedia.org/wiki/Unicode_equivalence
http://stackoverflow.com/questions/7931204/what-is-normalized-utf-8-all-about
The text was updated successfully, but these errors were encountered: