Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load only visible previews #6591

Closed
rnveach opened this issue Dec 30, 2013 · 3 comments
Closed

Load only visible previews #6591

rnveach opened this issue Dec 30, 2013 · 3 comments

Comments

@rnveach
Copy link
Contributor

rnveach commented Dec 30, 2013

I am on 6.0.0a (stable).
I was going ask to allow users the option to enable/disable previews, but I saw it already brought up in closed #5171, but it was discussed going with Filters instead of an enable/disable option. The only thing similar with what I am requesting, was with issue #3817, but it was never marked as going anywhere. I wasn't sure to add onto that issue, so I decided to start a new one.

One problem I have with the previews is that it displays an image for every file in the directory. If you are viewing a folder with 10 images, this is fine. But when you get to a folder with 100+ images, this can be a considerable download time and wasted bandwidth. The user may not even scroll through the entire listing, they could want to go to a deeper folder or be in the wrong folder, so there isn't a need to download most of the previews. And if the user is on a slow or limited connection, the previews could take a while to download. A filter probably wouldn't help with this issue as the entire folder is still loaded on the first pass before the user has a chance to apply the filter.

To help with the page load time, I think owncloud should implement "lazy load" of the preview images. Basically, the images are only loaded when the user scrolls them into view. The text file list is still loaded like normal, so the scroll bar wouldn't change in size.
I would still also like an option for enabling/disabling preview images for the user. The main case against this was having 2 different views, but I think this be done within 1 view. The lazy image load would just load a blank white image instead of the actual preview. This allows you to keep virtually the same code and page layout while giving users a bandwidth saving feature.

@PVince81
Copy link
Contributor

PVince81 commented Jan 8, 2014

Good point, the lazy loading of non-visible previews makes sense.

CC @owncloud/designers

@jancborchardt
Copy link
Member

This ties in with the original lazy loading issue at #251 because not only the previews are the cause for load.

@PVince81
Copy link
Contributor

Since we have infinite scrolling now, only the previews of the currently visible page/section are loaded. When you scroll down the next batch of previews is loaded when the next batch of rows is appended.
Closing.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants