Server-server sharing UX review

[jancborchardt]

Review of #8399
It’s fixes, does not need to block the feature merge for the freeze.

MUST FIX

• change wording to »Add to your ownCloud« (»Add« instead of Save, and also »your«) fix: drop unneeded code #9245
• button .icon-confirm instead of »Save« label to save space. Fix: use icon-confirm instead of text for accepting remote share, works better with translations #9426
• put in file without needing page reload
• in the file list, don’t show whole address but only username, and whole address on hover (tipsy tooltip) otherwise it gets too wide. And even then only show the top-level domain instead of the full path. Improved remote share owner display #9410
• show »you don’t have permissions here« info when public upload is not allowed
• ability to remove the share again (unshare it from you)

Popover (MUST FIX) – fixes at #9415

• remove exclamation mark
• relabel »Yes« to »Add share« and »No« to »Decline« to have it more descriptive
• move »Decline« to the left, »Add share« to the right to prevent accidental clicks

LATER --> see #9429

@schiesbn @icewind1991
@owncloud/designers

[PVince81]

• make the server field default to "https://" when no protocol was given

Autodetection seems to be broken, raised as #9097

[PVince81]

• Better error messages whenever mounting shares is not allowed either locally or remotely

[PVince81]

Setting to OC 7 CE

[PVince81]

I raised the "Add from link" enhancement as #9155

[PVince81]

@jancborchardt will you take care of this ?
Let me know if you need help with the more complex parts.

[craigpg]

@jancborchardt can you reduce the list of open issues to only contain the "must fix" issues for oC 7 CE?

[MorrisJobke]

I try to fix some of the design/UI related issues now and submit a PR soon.

[karlitschek]

Thanks @MorrisJobke

[MorrisJobke]

@jancborchardt We need to rework the button CSS for the public page ... it's completely broken and drives me nuts to get it working for all browsers.

[MorrisJobke]

@jancborchardt

• remove exclamation mark
• show thumbnail / preview /folder icon if possible
• relabel »Yes« to »Add share« and »No« to »Decline« to have it more descriptive
• move »Decline« to the left, »Add share« to the right to prevent accidental clicks

These points all involve the ocdialogs "class". Roughly we need to copy the code and adjust some parts to be able to introduce those changes. I don't think it's a good idea to do this just before the release. This needs a proper dialogs interface, because there are several wrappers to hide the complexity of this.

If it is nevertheless wanted I can add a wrapper with additional positioning and naming interface for the buttons and the template that should be used.

[jancborchardt]

@PVince81 @MorrisJobke I added your checkboxes to the original post.

[PVince81]

I'll have a look at the part about shortening the owner name in the file list.

[PVince81]

@MorrisJobke I just remembered that the prompt dialog was actually added by @icewind1991 as part of server to server sharing. So it is probably safe to make changes directly in oc-dialogs.js.

[schiessle]

These points all involve the ocdialogs "class". Roughly we need to copy the code and adjust some parts to be able to introduce those changes.

At least for the first point "remove exclamation mark" I would be in favor of changing it, even if we would change it system wide. I have no idea where we use this dialog beside server-to-server sharing, but this exclamation mark looks really confusing. Either remove it completely or replace it with a icon which looks like a icon and not like normal text.

[jancborchardt]

@schiesbn if you know where the exclamation mark is, can you remove it?

[PVince81]

@icewind1991 should know, he added that dialog.
Also @icewind1991 I noticed that there is a OC.dialogs.confirm() call, why didn't you just reuse that one but create a new one ?

[PVince81]

Ok got it, the prompt is in case there is a password required.

@jancborchardt the icon is of the class "ui-icon-notice".
Either replace it with a proper one or add "display: none" to it.
It seems to be generic for prompt/confirm dialogs (dialogs of type "notice")

[PVince81]

Please review owner share, discussion required: #9410

[PVince81]

I'll have a look at that prompt dialog and see if we can hack it to behave like we want.

[PVince81]

See #9415

[jancborchardt]

The relevant pull requests to work on / review are these:

• Improved external share dialog #9415 (Improved external share dialog) needs some final touches, see my comment on the bottom
• use icon-confirm instead of text for accepting remote share, works better with translations #9426 (use icon-confirm instead of text for accepting remote share) needs more testing!

@owncloud/designers please review and help :)

[jancborchardt]

Ok, so basically only one pull request is left to be opened, and that is for »Better error messages whenever mounting shares is not allowed either locally or remotely«.

I moved the other »LATER« ones into a new issue scheduled for ownCloud 8: #9429

[jancborchardt]

@PVince81 @schiesbn is the one remaining point »Better error messages whenever mounting shares is not allowed either locally or remotely« still planned for ownCloud 7, or should we move that to later -> ownCloud 8?

[MorrisJobke]

@jancborchardt The problem is also that the translations aren't updated anymore. THis needs to be done by hand -.-

[PVince81]

I think the current messages aren't that bad. So if we really want to change them later, then make it OC 8.

[jancborchardt]

Ok, moved the messages to the future issue at #9429

Closing this because everything is fixed! :)