Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP temp/memory stream instead of concat data in pure RAM #519

Open
DeepDiver1975 opened this issue Nov 18, 2022 · 0 comments
Open

Use PHP temp/memory stream instead of concat data in pure RAM #519

DeepDiver1975 opened this issue Nov 18, 2022 · 0 comments

Comments

@DeepDiver1975
Copy link
Member

    @jnweiger slightly related: 

public function onAsyncData($data) {
$this->data .= $data;
}

Such implementation will finally put the entire file content into RAM at the OC side. Which is basically a suboptimal approach.
onAsyncData method is supposed to send the data to the external scanner immediately instead of storing it.

Originally posted by @VicDeo in #437 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant