Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make action menu for thumbnails extensible with plugins #464

Closed
2 tasks
Bugsbane opened this issue Nov 10, 2015 · 5 comments
Closed
2 tasks

Make action menu for thumbnails extensible with plugins #464

Bugsbane opened this issue Nov 10, 2015 · 5 comments

Comments

@Bugsbane
Copy link

The new ... menu next to each file in the files app, is incredibly useful, and flexible. Often though, for certain folders made up of a lot of photos, I find myself using the gallery app to browse the files instead of the files app. The trouble is though, that often when I'm using the Gallery app I find myself needing to do various actions found in the ... menu, and switching back and forth between the file and gallery app constantly to do the same action for various files is very cumbersome.

I propose that we make the same ... menu, currently available in the files app available in the Gallery app, too. Specifically in the photowall view, that the ... appear in the top right of any image hovered over or long pressed. In the single image view, the ... would appear in the top right, overlaid. Given that download already exists in the ... menu, this would remove the need to have the current download arrow.

TODO

  • Action menu for thumbnails
  • Import plugin system from Files

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@oparoz
Copy link
Contributor

oparoz commented Nov 11, 2015

This is a duplicate of #39

@Bugsbane
Copy link
Author

No, this is significantly different. Both issues mention a menu for actions that can be performed on images, but that's about it. Issue 39 has a specific hard list of actions. What I am proposing is that we specifically use the same files_apps that are found in the current files app menu, which is far more extendable and modular.

For example, on my install, I have the files_move app installed. The implementation in #39 would ignore this. What I'm suggesting would also make move available in the image menu, just as it's now available in the files app menu.

@oparoz
Copy link
Contributor

oparoz commented Nov 17, 2015

#39 doesn't have a hard list of actions, those are suggestions, based on what people have mentioned as useful.

It's not possible to have a 3 dots menu like in Files without implementing a plugins system (#128). Then every app which adds their Javascript to Files will need to be modified to also inject their code into Gallery.

So:

  1. Menu
  2. Plugin system
  3. Convert apps

@oparoz oparoz reopened this Nov 17, 2015
@oparoz oparoz added this to the backlog milestone Nov 17, 2015
@oparoz oparoz changed the title Add 8.2's File Options ( ... ) Menu to Gallery Make thumbnail action menu (3 dots) configurable Nov 17, 2015
@Bugsbane
Copy link
Author

Fair enough.

@oparoz oparoz changed the title Make thumbnail action menu (3 dots) configurable Make action menu for thumbnails extensible with plugins Feb 21, 2016
@oparoz
Copy link
Contributor

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#103

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants