Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update CONFIGURATION.json (incomplete links) #1075

Closed
mmattel opened this issue Dec 11, 2021 · 1 comment
Closed

[BUG] Update CONFIGURATION.json (incomplete links) #1075

mmattel opened this issue Dec 11, 2021 · 1 comment
Assignees

Comments

@mmattel
Copy link
Contributor

mmattel commented Dec 11, 2021

Found a bug:

Found while working on: #1073 (Update ios_mdm_tables.adoc.tmpl)
Fixes: #1074 (Update CONFIGURATION.json)

The content in CONFIGURATION.json needs an update, see the refefenced PR which got closed, the file is created dynamically as @michaelstingl pointed in that PR. Therefore the change needs to be made in the source that creates the file.

It is not a big thing, three links to documents in this repo are not created as links because the full URI was not used. The .json file is used to generate the mdm table automatically and that file is used in the documentation - the content is visible on the web and the URI used should therefore be correct.

Note that I did not deleted the branch in the closed PR which makes it easier to check the changes made. When a new PR has been created fixing this issue, the branch in the closed PR can safely be deleted.

Expected behavior

Correct clickable link

Actual behavior

Link = text and incomplete not pointing to the source and therefore unfindable.

@michaelstingl @hosy @felix-schwarz @jesmrec

@hosy
Copy link
Collaborator

hosy commented Jan 19, 2022

@mmattel please can you point me which line needs an update in the adoc file and how it should looks like?

@jesmrec jesmrec changed the title [BUG] Update CONFIGURATION.json (inclomplete links) [BUG] Update CONFIGURATION.json (incomplete links) Mar 21, 2022
@hosy hosy closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants