Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Settings #3

Closed
8 tasks done
nasli opened this issue Feb 23, 2018 · 9 comments
Closed
8 tasks done

App Settings #3

nasli opened this issue Feb 23, 2018 · 9 comments

Comments

@nasli
Copy link
Contributor

nasli commented Feb 23, 2018

As an user I want be able to change some settings of the app so I can customize some features

To discuss, if settings are going to be per account or common to the app, or only some common

  • Create skeleton (view)

  • Settings sections:

    • Per app:
      • Security: Passcode/TouchId/FaceId/ [WIP]

         - Time slot until next time to request passcode/touch id/ face id
        
      • Instant uploads:

         - Photos: By enabling, all pics taken from camera will be queued in uploads queue, if the app is alive, or when the app is opened
        
         - Videos: By enabling, all video taken from camera will be queued in uploads queue, if the app is alive, or when the app is opened. https://github.com/owncloud/ios-app/issues/3#issuecomment-373005114
        
         - Background: the posibility of automatic upload when app is in background. A big change in location triggers the upload.
        
         - Wifi only: If it is enabled, stuff will be uploaded under wifi. Othercase, the stuff will be queued. When wifi is recovered, content will be uploaded. Same option for both pics and videos.
        
         - Account to upload: with only one account, this one is the selected. If there are more than one, user select one of the available. In case of deletion of the selected account, instant uploads will disable.
        
        - Target folder:  Folder into the selected account to upload instantly. Default: /InstalUploads. In case of removal, create again. 
        
        - Size: Size filter to upload content greater than. 
        
      • More: Help, recommend to a Friend, Send Feedback, Imprint

    • Per account:
      • Clear cache
  • Include version of the app and commit hash -> [Settings] Version and commit in settings view #51

  • Update Figma Design, get screenshot here

This is an epic, smaller issues will be created to develop in an incremental way

@nasli nasli added enhancement New feature or request feature:settings Design and removed enhancement New feature or request labels Feb 23, 2018
@nasli
Copy link
Contributor Author

nasli commented Mar 7, 2018

Updated settings sections, pending define design

@jesmrec
Copy link
Contributor

jesmrec commented Mar 7, 2018

It would be nice to have the possibility to select the target folder in which the content is uploaded

@jesmrec
Copy link
Contributor

jesmrec commented Mar 14, 2018

would it be interesting for the first iteration to set a filter to max size of video to upload. For example, for videos greater than 100MB (for instance), not to upload instantly.

@michaelstingl

@SamuAlfageme
Copy link

I'd say some of these settings should be moved to different issues as they're fundamental part of features.

Since @pablocarmu was looking into different apps using lock methods - I'll explain 3 personal picks:

App Lock Screen Settings Details
Bitwarden photo_2018-04-30_10-17-59 photo_2018-04-30_10-12-30
  • Lock Options
    • Immediately
    • 1 min
    • 15 min
    • ...
  • Choose one: PIN or Touch ID
  • Manual lock inside app
Standard Notes photo_2018-04-30_10-12-50 photo_2018-04-30_10-12-45
  • Lock Options
    • Immediately
    • On Quit
  • Passcode (can be alphanumeric/PIN) and Touch ID can be
    • Enabled separately
    • Required together
Authy photo_2018-04-30_10-12-50 2 photo_2018-04-30_10-12-52
  • Touch ID can only be enabled together with PIN and used alternatively
  • "Protect Entire App": require on start

@pablocarmu pablocarmu self-assigned this May 2, 2018
@jesmrec
Copy link
Contributor

jesmrec commented May 2, 2018

About the passcode, till this moment we use a 4 digit passcode. We will keep such behaviour, at least anyone wants other options (more digits, password policies...)

@michaelstingl @felix-schwarz @javiergonzper @pablocarmu

@michaelstingl
Copy link
Contributor

we can start with 4-digit. maybe we will need more in the future… (migration?)

@javiergonzper
Copy link
Contributor

Yes, if in the future we need more than 4 digits we can modify the UI an allow to our users use 4 digits, 6, alphabetical... whatever 👍.
I will do 4 digits then

@michaelstingl
Copy link
Contributor

Could we display the Git hash somewhere on the settings screen?

2018-05-13_21_36_48

@hosy
Copy link
Collaborator

hosy commented Oct 10, 2019

Last missing features are implemented since version 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants