Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Clarify uploading original assets vs edited assets #688

Closed
9 tasks
mneuwert opened this issue Apr 29, 2020 · 1 comment
Closed
9 tasks
Assignees

Comments

@mneuwert
Copy link
Contributor

Is your feature request related to a problem? Please describe.
iOS Library supports non-destructive editing of media assets. Thereby alongside with an original asset e.g. stored in HEIC format, adjustment data is stored (as PLIST) and cached latest output stored as JPEG image (which is basically original image data with operations described in Adjustments.plist applied).

Describe the solution you'd like
I think we need at least provide options to the user allowing him to choose what to upload: original, edited image or both.

Describe alternatives you've considered
Right now we just upload an original without providing any options

Additional context
Here is an example of Array of PHAssetResouce objects returned by PHAssetResource.assetResources(for asset:PHAsset):

[
{ type: photo, uni: public.heic, filename: IMG_3537.HEIC, isCurrent: NO},
{ type: adjustment, uni: com.apple.property-list, filename: Adjustments.plist, isCurrent: YES}
{ type: photo, uni: public.jpeg, filename: FullSizeRender.jpg, isCurrent: YES},
]

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@michaelstingl michaelstingl added this to the 11.5.0-Next milestone May 4, 2020
@mneuwert mneuwert self-assigned this May 11, 2020
@mneuwert mneuwert mentioned this issue Jul 27, 2020
12 tasks
@jesmrec
Copy link
Contributor

jesmrec commented Sep 24, 2020

Ready to go in 11.4.1

@jesmrec jesmrec closed this as completed Sep 24, 2020
@jesmrec jesmrec removed this from the 11.5.0-Current milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants