Enterprise demo (trial) process #107
Conversation
…ed api action so the frontend can use it
…also get keys from appconfig if necessary
add Sourcemaps for easier js debugging
make slicker trial form
| @@ -33,7 +33,8 @@ | |||
| ['name' => 'market#uninstall', 'url' => '/apps/{appId}/uninstall', 'verb' => 'POST'], | |||
| ['name' => 'market#getApiKey', 'url' => '/apikey', 'verb' => 'GET'], | |||
| ['name' => 'market#changeApiKey', 'url' => '/apikey', 'verb' => 'PUT'], | |||
|
|
|||
| ['name' => 'market#hasLicenseKey', 'url' => '/has-license-key', 'verb' => 'GET'], | |||
| ['name' => 'market#requestDemoLicenseKeyFromMarket', 'url' => '/request-license-key-from-market', 'verb' => 'GET'], | |||
There was a problem hiding this comment.
something which is named request used GET ?
There was a problem hiding this comment.
well, i really wasn't sure here, since it is not returning the subject itself, it makes sure the license key is available, and fetches it if not
There was a problem hiding this comment.
well - GET shall not change the server state - this call does change the server state -> no GET
There was a problem hiding this comment.
It does change the state of the server, but not by giving it information. It is basically a trigger for a background task. In this case GET, POST, PULL and PUSH are all wrong. GET seemed like the most sane solution.
There was a problem hiding this comment.
for a trigger I'd use POST - because it's state changing
| ); | ||
|
|
||
| if (!array_key_exists('license_key', $data)) { | ||
| throw new MarketException('Marketplace did not return a demo license key.'); |
There was a problem hiding this comment.
Yes, but it's not used to display in any userinterface.
There was a problem hiding this comment.
but what is returned to the user interface then?
both cases throw market exception - kind of unclear .....
| $demoLicenseKey = $data['license_key']; | ||
|
|
||
| if (!$demoLicenseKey) { | ||
| throw new MarketException('Marketplace returned an empty demo license key.'); |
There was a problem hiding this comment.
Yes, but it's not used to display in any userinterface.
| @@ -0,0 +1,11 @@ | |||
| <?php | |||
There was a problem hiding this comment.
missing file header with license ....
There was a problem hiding this comment.
ty, fixed! also in the other exception class
* added route for license key check * added functionallity to check if a license key is available, also added api action so the frontend can use it * make sure existing market app logic uses the getLicenseKey method to also get keys from appconfig if necessary * Add "Start trial" button and modal, add Sourcemaps for easier js debugging * Move API key settings to the menu, make slicker trial form * added exceptions * added method to request and save the demo license key from the marketplace * added api endpoint to load the demo license key from the marketplace * fixed false appconfig key * Improve EE Trial process [WIP] * Fix license error * fixed EnterpriseKey usage * Finalise trial process * added missing license header
* added route for license key check * added functionallity to check if a license key is available, also added api action so the frontend can use it * make sure existing market app logic uses the getLicenseKey method to also get keys from appconfig if necessary * Add "Start trial" button and modal, add Sourcemaps for easier js debugging * Move API key settings to the menu, make slicker trial form * added exceptions * added method to request and save the demo license key from the marketplace * added api endpoint to load the demo license key from the marketplace * fixed false appconfig key * Improve EE Trial process [WIP] * Fix license error * fixed EnterpriseKey usage * Finalise trial process * added missing license header
This PR contains the UI and backend for the trial process feature. It requests the demo license key from the marketplace, saves the key in appconfig and installs all enterprise applications.
Additionally the enterprise_key app will be able to load enterprise keys from the appconfig if there is no key configured in config.php.