-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cluster setup #125
Handle cluster setup #125
Conversation
@DeepDiver1975 tests? ;) |
254c26d
to
fec1b6e
Compare
This is ready to be reviewed and merged as soon as we did release 10.0.3 |
So does it need to wait or should it be released as part of 10.0.3 ? 😕 |
should be part of 10.0.3 from my pov - I could relax the dependency and use some defensive coding ... method_exists .... |
so we should get this merged then |
@@ -580,4 +591,13 @@ public function requestLicenseKey() { | |||
|
|||
return $demoLicenseKey; | |||
} | |||
|
|||
public function canInstall() { | |||
if (!method_exists($this->appManager, 'canInstall')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add TODO: remove once min-version is set to 10.0.3+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 otherwise
@DeepDiver1975 backport to stable10 please |
there is much more stuff missing afaik .... will take care later ... |
damn ... did we backport anything? |
Shouldn't this also address #123 (no update when directory not writeable) |
yes - closed - thx |
Blocker - needs 10.0.3 release upfront - see owncloud/core#28543