Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cluster setup #125

Merged
merged 5 commits into from
Aug 14, 2017
Merged

Handle cluster setup #125

merged 5 commits into from
Aug 14, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 31, 2017

@VicDeo
Copy link
Member

VicDeo commented Jul 31, 2017

@DeepDiver1975 tests? ;)

@DeepDiver1975
Copy link
Member Author

This is ready to be reviewed and merged as soon as we did release 10.0.3

@PVince81
Copy link
Contributor

This is ready to be reviewed and merged as soon as we did release 10.0.3

So does it need to wait or should it be released as part of 10.0.3 ? 😕

@DeepDiver1975
Copy link
Member Author

So does it need to wait or should it be released as part of 10.0.3 ? 😕

should be part of 10.0.3 from my pov - I could relax the dependency and use some defensive coding ... method_exists ....

@PVince81
Copy link
Contributor

so we should get this merged then

@@ -580,4 +591,13 @@ public function requestLicenseKey() {

return $demoLicenseKey;
}

public function canInstall() {
if (!method_exists($this->appManager, 'canInstall')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add TODO: remove once min-version is set to 10.0.3+

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 otherwise

@PVince81 PVince81 mentioned this pull request Aug 14, 2017
@PVince81 PVince81 merged commit 5ab51f7 into master Aug 14, 2017
@PVince81 PVince81 deleted the handle-cluster-setup branch August 14, 2017 12:37
@PVince81
Copy link
Contributor

@DeepDiver1975 backport to stable10 please

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 backport to stable10 please

there is much more stuff missing afaik .... will take care later ...

@DeepDiver1975
Copy link
Member Author

damn ... did we backport anything?

@DeepDiver1975
Copy link
Member Author

#131

@patrickjahns
Copy link
Contributor

Shouldn't this also address #123 (no update when directory not writeable)

@DeepDiver1975
Copy link
Member Author

Shouldn't this also address #123 (no update when directory not writeable)

yes - closed - thx

@DeepDiver1975 DeepDiver1975 modified the milestones: development, QA Sep 15, 2017
@patrickjahns patrickjahns mentioned this pull request Nov 13, 2017
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants