Marketplace login #443

IljaN · 2019-01-23T14:00:31Z

Login directly from market-app to auto-install your api-key.

Market app send its callback-url and PKCE-Challenge to marketplace.
A marketplace login and approval prompt is presented to the user.
If user approves prompt, a one-time token is generated and forwarded to the market app.
The Token is used together with PKCE-Verify-code by market app to retrieve the api-key.

This PR can be tested against staging marketplace by setting appstoreurl.

This is NOT OAuth because OAuth requires a static callback-url

Closes #425

codecov · 2019-01-23T14:32:30Z

Codecov Report

Merging #443 into master will decrease coverage by 3.36%.
The diff coverage is 1.56%.

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
- Coverage     51.57%   48.21%   -3.37%     
- Complexity      255      266      +11     
============================================
  Files            17       17              
  Lines           888      952      +64     
============================================
+ Hits            458      459       +1     
- Misses          430      493      +63

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/PageController.php	`80% <0%> (-20%)`	`2 <1> (+1)`
lib/Controller/MarketController.php	`0% <0%> (ø)`	`41 <4> (+5)`	⬆️
lib/HttpService.php	`40.54% <0%> (-6.83%)`	`32 <3> (+3)`
appinfo/routes.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/MarketService.php	`47.65% <5.26%> (-3.73%)`	`83 <2> (+2)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958725c...73a8629. Read the comment docs.

codecov · 2019-01-23T14:32:32Z

Codecov Report

Merging #443 into master will increase coverage by 1.39%.
The diff coverage is 57.74%.

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
+ Coverage     51.57%   52.97%   +1.39%     
- Complexity      255      267      +12     
============================================
  Files            17       17              
  Lines           888      959      +71     
============================================
+ Hits            458      508      +50     
- Misses          430      451      +21

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/MarketController.php	`0% <0%> (ø)`	`41 <4> (+5)`	⬆️
appinfo/routes.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/Controller/PageController.php	`100% <100%> (ø)`	`2 <1> (+1)`	⬆️
lib/MarketService.php	`59.14% <100%> (+7.76%)`	`83 <2> (+2)`	⬆️
lib/HttpService.php	`55.08% <86.95%> (+7.71%)`	`33 <4> (+4)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 958725c...6e800a7. Read the comment docs.

VicDeo

@IljaN Looks good in general. See a few comments.
Vue templates are already indented with spaces so the formatting looks weird for them.

lib/Controller/MarketController.php

lib/HttpService.php

IljaN · 2019-01-30T13:14:41Z

@VicDeo Adressed your changes. Tough not sure about:

Vue templates are already indented with spaces so the formatting looks weird for them.

Care to explain?

IljaN · 2019-01-30T13:59:19Z

Please don't merge yet

src/App.vue

VicDeo · 2019-01-30T14:09:48Z

@IljaN open the diff for src/App.vue here and you see that your changes are not aligned with the rest in this file. I spotted out one line, the rest are same (tabs instead of spaces)

IljaN · 2019-01-30T14:39:31Z

Hmhh App.vue seems to be mixed, sometimes tabs, sometimes spaces 🙈

IljaN · 2019-01-31T10:09:39Z

@VicDeo Please re-review

VicDeo

Feel free to merge after adding type hints into PHP doc blocks.

It would be good to squash at least commits 1-5 to compact the history. But it's up to you.

VicDeo · 2019-01-31T20:41:56Z

lib/HttpService.php

+	 *
+	 * Exchange login token for api key
+	 *
+	 * @param $loginToken


type is missing

VicDeo · 2019-01-31T20:42:03Z

lib/HttpService.php

+	 * Exchange login token for api key
+	 *
+	 * @param $loginToken
+	 * @param $codeVerifier


type is missing

VicDeo · 2019-01-31T20:42:14Z

lib/HttpService.php

@@ -273,6 +295,40 @@ private function httpGet($path, $options, $apiKey) {
 		return $response;
 	}

+	/**
+	 * @param $path


type is missing

VicDeo · 2019-01-31T20:42:47Z

lib/HttpService.php

@@ -273,6 +295,40 @@ private function httpGet($path, $options, $apiKey) {
 		return $response;
 	}

+	/**
+	 * @param $path
+	 * @param $options


type is missing

IljaN self-assigned this Jan 23, 2019

IljaN force-pushed the marketplace_login branch 2 times, most recently from 74795d5 to ff20088 Compare January 25, 2019 17:07

IljaN requested review from VicDeo and settermjd January 25, 2019 17:10

IljaN changed the title ~~[WIP] Marketplace login~~ Marketplace login Jan 25, 2019

VicDeo reviewed Jan 28, 2019

View reviewed changes

lib/Controller/MarketController.php Outdated Show resolved Hide resolved

lib/Controller/MarketController.php Show resolved Hide resolved

lib/HttpService.php Show resolved Hide resolved

lib/HttpService.php Show resolved Hide resolved

VicDeo reviewed Jan 30, 2019

View reviewed changes

src/App.vue Show resolved Hide resolved

VicDeo approved these changes Jan 31, 2019

View reviewed changes

IljaN and others added 3 commits February 1, 2019 09:47

Marketplace login #425

2f0bd8a

Display login status to user

82ab415

Convert to tabs

6e800a7

IljaN force-pushed the marketplace_login branch from f332a64 to 6e800a7 Compare February 1, 2019 08:48

IljaN merged commit 9effe15 into master Feb 1, 2019

delete-merged-branch bot deleted the marketplace_login branch February 1, 2019 08:58

PVince81 mentioned this pull request Feb 8, 2019

Market 0.4.0 #447

Closed

26 tasks

PVince81 added this to the QA milestone Feb 25, 2019

davitol mentioned this pull request Mar 5, 2019

Tracking testing results for market 0.4.0 #455

Closed

DeepDiver1975 mentioned this pull request Oct 20, 2023

chore: remove unused code #1283

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marketplace login #443

Marketplace login #443

IljaN commented Jan 23, 2019 •

edited

Loading

codecov bot commented Jan 23, 2019

codecov bot commented Jan 23, 2019 •

edited

Loading

VicDeo left a comment

IljaN commented Jan 30, 2019 •

edited

Loading

IljaN commented Jan 30, 2019

VicDeo commented Jan 30, 2019

IljaN commented Jan 30, 2019

IljaN commented Jan 31, 2019

VicDeo left a comment

VicDeo Jan 31, 2019

VicDeo Jan 31, 2019

VicDeo Jan 31, 2019

VicDeo Jan 31, 2019

Marketplace login #443

Marketplace login #443

Conversation

IljaN commented Jan 23, 2019 • edited Loading

codecov bot commented Jan 23, 2019

Codecov Report

codecov bot commented Jan 23, 2019 • edited Loading

Codecov Report

VicDeo left a comment

Choose a reason for hiding this comment

IljaN commented Jan 30, 2019 • edited Loading

IljaN commented Jan 30, 2019

VicDeo commented Jan 30, 2019

IljaN commented Jan 30, 2019

IljaN commented Jan 31, 2019

VicDeo left a comment

Choose a reason for hiding this comment

VicDeo Jan 31, 2019

Choose a reason for hiding this comment

VicDeo Jan 31, 2019

Choose a reason for hiding this comment

VicDeo Jan 31, 2019

Choose a reason for hiding this comment

VicDeo Jan 31, 2019

Choose a reason for hiding this comment

IljaN commented Jan 23, 2019 •

edited

Loading

codecov bot commented Jan 23, 2019 •

edited

Loading

IljaN commented Jan 30, 2019 •

edited

Loading