OCS status code zero

[phil-davis]

While bumping the core commit id for API tests, there is this new failure:
https://drone.owncloud.com/owncloud/ocis/11072/27/6

  Scenario: Keep usergroup shares when the user renames the share within the Shares folder(#22143) # /srv/app/testrunner/tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature:32
    Given group "grp1" has been created                                                            # FeatureContext::groupHasBeenCreated()
    And user "Brian" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Carol" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Alice" has created folder "/TMP"                                                     # FeatureContext::userHasCreatedFolder()
    When user "Alice" shares folder "TMP" with group "grp1" using the sharing API                  # FeatureContext::userSharesFileWithGroupUsingTheSharingApi()
    And user "Brian" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Carol" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Brian" moves folder "/Shares/TMP" to "/Shares/new" using the WebDAV API              # FeatureContext::userMovesFileUsingTheAPI()
    And the administrator deletes user "Carol" using the provisioning API                          # FeatureContext::theAdminDeletesUserUsingTheProvisioningApi()
    Then the OCS status code of responses on all endpoints should be "100"                         # FeatureContext::theOCSStatusCodeOfResponsesOnAllEndpointsShouldBe()
      Responses did not return expected ocs status code
      Failed asserting that 0 is identical to 100.

This test scenario has recently been adjusted to check all the status codes. It passes in oC10 core.

First investigate if this is a test problem - maybe there is some problem with the test processing the status codes.

Then, if there is a real problem with oCIS, raise an issue about it.

[butonic]

response when accepting merged shares is fixed with cs3org/reva#2830

[micbar]

@phil-davis Does that fix the problem?

[phil-davis]

@phil-davis Does that fix the problem?

https://drone.owncloud.com/owncloud/ocis/11704/43/6

  Scenario: Keep usergroup shares when the user renames the share within the Shares folder(#22143) # /srv/app/testrunner/tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature:32
    Given group "grp1" has been created                                                            # FeatureContext::groupHasBeenCreated()
    And user "Brian" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Carol" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Alice" has created folder "/TMP"                                                     # FeatureContext::userHasCreatedFolder()
    When user "Alice" shares folder "TMP" with group "grp1" using the sharing API                  # FeatureContext::userSharesFileWithGroupUsingTheSharingApi()
    And user "Brian" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Carol" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Brian" moves folder "/Shares/TMP" to "/Shares/new" using the WebDAV API              # FeatureContext::userMovesFileUsingTheAPI()
    And the administrator deletes user "Carol" using the provisioning API                          # FeatureContext::theAdminDeletesUserUsingTheProvisioningApi()
    Then the OCS status code of responses on all endpoints should be "100"                         # FeatureContext::theOCSStatusCodeOfResponsesOnAllEndpointsShouldBe()
      Responses did not return expected ocs status code
      Failed asserting that 0 is identical to 100.
    And the HTTP status code of responses on all endpoints should be "200"                         # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
    And user "Brian" should see the following elements                                             # FeatureContext::userShouldSeeTheElements()
      | /Shares/new/ |

A recent oCIS CI run still has the same reason for failing.

I will find a recent reva CI run and post that also.

[phil-davis]

https://drone.cernbox.cern.ch/cs3org/reva/7058/14/6

  Scenario: Keep usergroup shares when the user renames the share within the Shares folder(#22143) # /drone/src/tmp/testrunner/tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature:32
    Given group "grp1" has been created                                                            # FeatureContext::groupHasBeenCreated()
    And user "Brian" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Carol" has been added to group "grp1"                                                # FeatureContext::userHasBeenAddedToGroup()
    And user "Alice" has created folder "/TMP"                                                     # FeatureContext::userHasCreatedFolder()
    When user "Alice" shares folder "TMP" with group "grp1" using the sharing API                  # FeatureContext::userSharesFileWithGroupUsingTheSharingApi()
    And user "Brian" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Carol" accepts share "/TMP" offered by user "Alice" using the sharing API            # FeatureContext::userReactsToShareOfferedBy()
    And user "Brian" moves folder "/Shares/TMP" to "/Shares/new" using the WebDAV API              # FeatureContext::userMovesFileUsingTheAPI()
INFORMATION: could not delete user 'Carol' 401 
    And the administrator deletes user "Carol" using the provisioning API                          # FeatureContext::theAdminDeletesUserUsingTheProvisioningApi()
    Then the OCS status code of responses on all endpoints should be "100"                         # FeatureContext::theOCSStatusCodeOfResponsesOnAllEndpointsShouldBe()
      Responses did not return expected ocs status code
      Failed asserting that 0 is identical to 100.
    And the HTTP status code of responses on all endpoints should be "200"                         # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
    And user "Brian" should see the following elements                                             # FeatureContext::userShouldSeeTheElements()
      | /Shares/new/ |

It still fails the same in reva edge.

[micbar]

@butonic I thought we fixed it?

[S-Panta]

In the test code, $this->emptyLastHTTPStatusCodesArray() and $this->emptyLastOCSStatusCodesArray() was used before the user deletion step and thus OCS response is found as 0. This step is passed in this PR #7020 and this issue can be closed.

[ScharfViktor]

won't be fixed because we're going to get rid of OCS api.