Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload failure message when disk full #3767

Closed
wkloucek opened this issue May 11, 2022 · 2 comments
Closed

upload failure message when disk full #3767

wkloucek opened this issue May 11, 2022 · 2 comments
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@wkloucek
Copy link
Contributor

Describe the bug

when uploading a file on a oCIS instance with full disk we don't have a speaking error message.

Steps to reproduce

Steps to reproduce the behavior:

  1. have an oCIS instance
  2. have your disk full
  3. upload a file larger than the remaining free disk space

Expected behavior

Have an error message: "upload failed because not sufficient space on the target system"

Actual behavior

error message: "upload failed"

image

The log says:
{"level":"error","service":"storage-users","pkg":"rgrpc","traceid":"00000000000000000000000000000000","error":"error: insufficient storage: disk full","status":{"code":19,"message":"insufficient storage","trace":"00000000000000000000000000000000"},"time":"2022-05-11T11:58:59Z","message":"failed to initiate upload"}

Setup

oCIS 2.0.0-beta1 on a server with constrained disk

@micbar micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label May 11, 2022
@pascalwengerter
Copy link
Contributor

pascalwengerter commented May 11, 2022

If OCIS responds with e.g. a 507 we could check for that in web and then render (translated) strings to the UI, which AFAIK the backend is not able to

@dragonchaser dragonchaser self-assigned this May 17, 2022
@dragonchaser
Copy link
Member

There is a PR on reva: cs3org/reva#2891 to fix this.
@pascalwengerter a 507 is returned as soon as said PR is merged, I thin kthis needs handling in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Archived in project
Development

No branches or pull requests

4 participants