Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role interaction not consistent between collaborators and link share #1907

Closed
PVince81 opened this issue Sep 5, 2019 · 10 comments · Fixed by #2841
Closed

Role interaction not consistent between collaborators and link share #1907

PVince81 opened this issue Sep 5, 2019 · 10 comments · Fixed by #2841
Assignees
Labels
Estimation:L(5) Priority:p2-high Escalation, on top of current planning, release blocker Type:Design

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 5, 2019

Feedback

Link share has a radio group for roles and takes a lot of vertical space:
image

(also see font size is too big issue)

User share has a single line with dropdown that appears when clicked:
image

To save vertical space, especially on screens like mine, it might be better to always use the "single line role" pattern also for the public link shares.

If we consider that a user is already familiar with how roles work, it might be a good idea to always provide them with the same experience: same controls, same interaction.

Version

Phoenix master 2f7b3d7

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 24, 2019
@PVince81 PVince81 added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 24, 2019
@wuenschedesign
Copy link

wuenschedesign commented Oct 22, 2019

The following screens show the user flow for creating a public link. Issues concerning roles/permissions are not yet solved in this draft.

Add-Public-Link-00
Add-Public-Link-01
Add-Public-Link-02
Add-Public-Link-03
Add-Public-Link-04
Add-Public-Link-05
Add-Public-Link-06
Add-Public-Link-07

@wuenschedesign
Copy link

wuenschedesign commented Oct 23, 2019

The following Screens show a different approach to create a public link in the sidebar without making a modal.

Screen (1)
User starts creating a public link:

Sidebar-01

Screen (2)
Screenview when changing the role:

Sidebar-02

Screen (3)
A completely filled sidebar including an open date picker:

Sidebar-03

Screen (4)
Public Link added in the sidebar:

Sidebar-04

@wuenschedesign
Copy link

New drafts for creating public link:

Links-01
Sidebar-Public-Link-01
Sidebar-Public-Link-02
Sidebar-Public-Link-03
Sidebar-Public-Link-04A

@PVince81
Copy link
Contributor Author

for email field, let's implement later on: #2422

@wuenschedesign
Copy link

Additional layout for the public link creation:

Layout:
List-View-Creating-Public-Link

Layout with comments:
List-View-Creating-Public-Link-comments

@wuenschedesign
Copy link

We also need a concept how to define the process of creating a public link.

  1. Prompt for informing a user that he is about to cancel the process:
    List-View-Creating-Public-Link-Cancel

  2. Notification for the user that he has created a public link (even, if he unintentionally clicked somewhere else). Alternatively no link will be created, as long as the user didn’t input any information:
    List-View-Creating-Public-Link-Succesfully-created

@PVince81
Copy link
Contributor Author

Update: we decided to go with the "in-panel" editing where a new panel comes and overlap.

This approach was already used for collaborators and now need to be applied for the public link workflows as well. Please ignore the above mock ups which were part of an older design.

@wuenschedesign did we have updated mock ups somewhere in another ticket ? Somehow I can't find them any more. It's not a big issue as developers can simply align the design of public links with the current one from collaborators (and reuse the existing Vue components like the roles selector)

@kulmann @micbar

@wuenschedesign
Copy link

@wuenschedesign did we have updated mock ups somewhere in another ticket ? Somehow I can't find them any more. It's not a big issue as developers can simply align the design of public links with the current one from collaborators (and reuse the existing Vue components like the roles selector)

In which way should they be updated?

@PVince81
Copy link
Contributor Author

@wuenschedesign the mock ups above are outdated as they show the modal approach.

I thought we already had some where the public link panel editing was represented, maybe in some other ticket ?

@kulmann
Copy link
Member

kulmann commented Dec 19, 2019

Any news on this for mockups? ;-) Not necessary, but would still be helpful. @PVince81 @wuenschedesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation:L(5) Priority:p2-high Escalation, on top of current planning, release blocker Type:Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants