-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Role interaction not consistent between collaborators and link share #1907
Comments
The following Screens show a different approach to create a public link in the sidebar without making a modal. Screen (1) Screen (2) Screen (3) Screen (4) |
for email field, let's implement later on: #2422 |
We also need a concept how to define the process of creating a public link. |
Update: we decided to go with the "in-panel" editing where a new panel comes and overlap. This approach was already used for collaborators and now need to be applied for the public link workflows as well. Please ignore the above mock ups which were part of an older design. @wuenschedesign did we have updated mock ups somewhere in another ticket ? Somehow I can't find them any more. It's not a big issue as developers can simply align the design of public links with the current one from collaborators (and reuse the existing Vue components like the roles selector) |
In which way should they be updated? |
@wuenschedesign the mock ups above are outdated as they show the modal approach. I thought we already had some where the public link panel editing was represented, maybe in some other ticket ? |
Any news on this for mockups? ;-) Not necessary, but would still be helpful. @PVince81 @wuenschedesign |
Feedback
Link share has a radio group for roles and takes a lot of vertical space:
(also see font size is too big issue)
User share has a single line with dropdown that appears when clicked:
To save vertical space, especially on screens like mine, it might be better to always use the "single line role" pattern also for the public link shares.
If we consider that a user is already familiar with how roles work, it might be a good idea to always provide them with the same experience: same controls, same interaction.
Version
Phoenix master 2f7b3d7
The text was updated successfully, but these errors were encountered: