Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.6.0 #6091

Closed
22 of 23 tasks
pascalwengerter opened this issue Dec 3, 2021 · 5 comments · Fixed by #6093
Closed
22 of 23 tasks

Release 4.6.0 #6091

pascalwengerter opened this issue Dec 3, 2021 · 5 comments · Fixed by #6093

Comments

@pascalwengerter
Copy link
Contributor

pascalwengerter commented Dec 3, 2021

Release checklist

  • pin release issue @pascalwengerter
  • Merge Bump ODS to v11.3.0 #6090 @pascalwengerter
  • prepare release rc: @pascalwengerter
  • create pre release tag v4.6.0-rc1 from the release branch @pascalwengerter
  • smoke test
  • if needed, fix issues or write down known issues
  • update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
  • Make sure translations are up to date
  • repeat above steps if a new rc is needed
  • Run translations sync job once again
  • go to the releases section and click Draft a new Release. Use v4.6.0 as a tag (the v prefix is important) and 4.6.0 as name and publish it
  • ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
  • merge release branch Prepare 4.6.0 #6093 back to master (CI must be green)
@pascalwengerter
Copy link
Contributor Author

pascalwengerter commented Dec 6, 2021

Smoke test standalone against oc10

  • ❌ as admin - upload 20.000 files in 7 folders to home (core apps directory, Firefox on Ubuntu)

    • upload via New files button just completely freezes the tab and doesn't even start uploading according to backend logs.
    • upload via Dropzone takes forever, slowly running counter in the progress bar but no requests in the backend logs anymore at some point. Unclear amount of files&foulders have been actually uploaded
  • ✔️ as admin - share the folder as viewer

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected

    • ✔️ Buttons in shared with me table
    • ✔️ batch action
    • ❌ right sidebar not open-able
    • ❌ contextmenu not visible
  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop doesnt work, which is acceptable

  • ✔️ as alice - copy 100 files from share to home

    • move from shared folder makes browser lag alot sometimes freeze
    • "size" is shown as question mark for copied folder until navigating into them
  • ✔️ as admin - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as admin - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as admin - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as admin - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ❌ as alice create version of textfile (dialogue shows up, but sometimes version tab in sidebar is missing, if it's there it doesn't show new versions so further steps here are not possible)

  • ❌ as alice view version history of text file

  • ❌ as alice download newest version of text file

  • ❌ download older version of text file

  • ❌ restore older version of text file

    • no visible feedback about the success
    • preview is updated
  • ✔️ as alice - upload avatar in classic UI

    • login as admin, having a share with alice
    • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with admin

  • ✔️ as alice, navigate into a folder, use breadcrumb context menu, share current folder with admin

Found some regressions

Update: Investigated with @fschade, there's buggy behavior in SharedWithMe.vue regarding contextmenu actions (both in the passed item(s) and how filtering for the actions works)

@kulmann
Copy link
Member

kulmann commented Dec 6, 2021

Smoke test rc1 against oc10 app

  • ✔️ as gunter - upload arch/mips folder from linux kernel (1945 files)

    • progress bar is not sticky
    • expanding the upload progress section slows down browser & upload time significantly
  • ✔️ as gunter - share the folder to alice as viewer
    - sharing is not possible before the upload finished (user invite field doesn't stay focussed)

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)
    - ❌ as alice, accepting or declining shares via context menu is broken!
    - ❌ as alice, selecting an accepted share, right-click-declining it will not remove it from the selection, leading to weird batch action buttons being displayed

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected) but drag & drop upload didn't handle it. opened file in new tab instead.

  • ❌ as alice - copy 16 folders from share to home

    • no visible feedback that it's in progress
    • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.
    • folder listing after copy shows ? as folder size on some of the copied folders.
  • ✔️ as gunter - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good
  • ✔️ as gunter - share folder with alice again, but as editor

  • ✔️ as alice - rename file

    • via right sidebar, works, good
    • via context menu, works, good
  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
    • via batch action, works, good
  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ❌ as alice download newest version of text file
    - versions table is too wide on medium sized screens, buttons (right column of table) are rendered off screen

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is not updated
  • ✔️ as alice - upload avatar in classic UI

    • see own avatar in top bar (far right)
    • login as gunter, having a share with alice
      • shared with others page loads and shows avatars
  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, move multiple files & folders into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

Remarks about smoke testing findings from previous release:

  • selecting an accepted share, right-click-declining it will not remove it from the selection, leading to weird batch action buttons being still displayed. This is not a regression of this release, was broken before. => will be fixed in [full-ci] Prepare batch actions in contextmenu #5973 -> somehow we made it worse by killing the context menu on the shared with me page
  • download as default action (triggered on left click on a file) doesn't work -> was fixed ✔️

Findings from new smoke testing:

  • context menu in shared with me is broken! fixed in 07ea58f
  • versions table is too wide on medium sized screens, buttons (right column of table) are rendered off screen

@ScharfViktor
Copy link
Contributor

SmokeTest against ocis

branch: v4.6.0-rc1

Case 1: admin share folder(with file) to marie:

Admin:

  • upload big file 30gb - backend error: {"level":"error","service":"storage","pkg":"rhttp","traceid":"00000000000000000000000000000000","host":"127.0.0.1","method":"PUT","uri":"/remote.php/webdav/temp_30GB_file","url":"/remote.php/webdav/temp_30GB_file","proto":"HTTP/1.1","status":507,"size":0,"start":"06/Dec/2021:23:25:05 +0000","end":"06/Dec/2021:23:25:05 +0000","time_ns":2020625,"time":"2021-12-06T23:25:05Z","message":"http"}
  • upload big file 10gb - very slow
  • upload folder with 848 files.
  • Check pagination, count items per page.
    ❌ - [ ] Choose 100 files and try to delete - very slow. the modal window remains on the screen. If you click cancel - file deletion will continue
  • upload folder(drag folder) "folder_to_share" with file.pdf
  • share folder "folder_to_share" to marie with edit right

Marie:

  • accept "folder_to_share"
    ❌ - when you click of the hamburger icon (3 point) you don't get context menu

  • rename "folder_to_share" (?admin don't see)

  • upload new file "file.txt" to "folder_to_share" (admin see new file)

  • open pdf file

  • rename file.pdf (use rigth click) (admin see that file changed name)

  • try to move "folder_to_share" to "/" (400)

  • copy "folder_to_share" to "/"

Admin:

  • add new file.jpeg to "folder_to_share" (marie can see file without access)
  • add file format drawio(marie can open in Draw.io and can edit)
  • move file.pdf to "/" (marie can not see file.pdf)
  • add new "file.txt" create new version. (marie can see new version)
  • open txt file in markdown-editor. Change and save. ❌ created a file with UUID name in "All files"

Marie:

  • can download both versions (!error 501)
  • restore old version

Admin:

  • change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

  • [] decline folder (but folder exist in Shares - bug) - existing bug

Admin:

  • delete folder "folder_to_share" (marie: folder Shares empty)

Case 2: admin share file to marie:

Admin:

  • upload file.jpeg
  • share file.jpeg to marie with rigth viewer (use main menu. find marie by email [email protected])

Marie:

  • accept file (marie can open/download/copy file but cannot delete/move/rename)
  • copy file to "/"
  • open file in Mediaviewer
  • download file

Admin:

  • change share "file.jpeg" from "viewer" to "edit"(marie can open/download/copy/rename file)

Marie:

  • rename file (admin don't see)

Admin:

  • unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

  • create folder "for upload"
  • add link with name "to_upload" with role "Uploader" with pass and expiration date
  • open link (can only upload)
  • upload file (admin can see new file)
  • refresh page(page is empty)
  • change share "for upload" from "Uploader" to "edit"
  • open old link (it work as upload)
  • open new link (can open/download/copy/rename/move files)
  • admin add new file to "for upload"
  • refresh link (file exist)
  • admin change pass (refresh link)

Case 4: admin create link to file

Admin:

  • create file png

  • add link with main menu

  • open link(can open, download, see) in the incognito tab

  • change link, add pass

  • refresh page (input pass)

  • delete link

  • refresh page (resource not found)

  • delete file

  • restore

  • delete

  • Empty trash

Case 5: create new user:

Admin:

  • create new account "tom"

Tom:

  • go to account
  • change language

Admin:

  • block user (Login Error access denied)
  • delete user (Logon failed)
  • logout

@kulmann
Copy link
Member

kulmann commented Dec 7, 2021

Fixed context menu on shared with me page with a commit in this branch: 07ea58f

@pascalwengerter
Copy link
Contributor Author

Fixed sidebar version button visibility on 5865d4a89884539df0fd12a940f088e8cff0c371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants