Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a share/space member: show confirmation dialog #6728

Closed
tbsbdr opened this issue Apr 4, 2022 · 2 comments · Fixed by #6795
Closed

Remove a share/space member: show confirmation dialog #6728

tbsbdr opened this issue Apr 4, 2022 · 2 comments · Fixed by #6795
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Apr 4, 2022

Steps to reproduce

  1. go to https://web.owncloud.com/ -> new design
  2. share a file with group "admin"
  3. "Shared with" list: click on 3-dots -> remove share

Expected behaviour

A confirmation dialog shows up so that I can confirm my action:

Remove share <displayname>?
Are you sure you want to remove this share?
[Cancel] [Remove]

Actual behaviour

Share gets removed immediately

Background:

Action should be confirmed as there is no easy undo / restore action.

@kulmann
Copy link
Member

kulmann commented Apr 4, 2022

Why is the action irreversible? 🤔 I can easily recreate the share.

I agree that it should have a confirm dialog. But only because there is no undo and no restore action.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Apr 5, 2022

irreversible

correct, thx - updated initial post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants