Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy/move only works with personal space #6892

Closed
kulmann opened this issue May 6, 2022 · 12 comments · Fixed by #7652 or #7735
Closed

Copy/move only works with personal space #6892

kulmann opened this issue May 6, 2022 · 12 comments · Fixed by #7652 or #7735
Assignees
Labels
Interaction:Needs-Concept Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented May 6, 2022

With the share jail being merged the LocationPicker view, which let's you select a target location for a copy or move action, only lists a single webdav endpoint, namely the personal space. As each accepted share and any project space have their own webdav endpoint we need to come up with a solution to list alternative target locations. This is a regression and needs to be tackled as soon as possible.

Steps to reproduce

  1. Visit personal space
  2. Select "Copy" or "Move" in the right-click context menu of any file or folder

Expected behaviour

Get presented with all available target locations and be able to navigate into any of their subfolders

Actual behaviour

Only see the content of the personal space

Things to consider

This is not just a matter of listing all available webdav endpoints in the LocationPicker view. It requires further UX adaoptions in the web UI. As a cross-storage-move in reality is a combination of copy and delete backend-side it is in fact a slow operation. Probably important to make this transparent to the user. One solution could be that our until now separated Copy and Move actions in the web UI get merged into one Copy or move action. The LocationPicker view could then have multiple submit buttons, depending on what operation is available in the target location, e.g. Move, Copy or Copy and delete.

First step

Needs a clear UI/UX concept. Nothing to implement, yet.

Followup tasks when this is done

  • re-enable the Copy and Move actions in the spaces share route / SharedResource view

cc @tbsbdr @butonic

@kulmann
Copy link
Member Author

kulmann commented Jun 20, 2022

This has been mitigated via keyboard actions which are available on all relevant views now (Personal, shares/SharedResource, spaces/Project and PublicFiles). This also enables cross-webdav-endpoint copy / move in the web ui.

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 23, 2022

This also enables cross-webdav-endpoint copy / move in the web ui.

awesome 🤩

@lookacat lookacat self-assigned this Jul 18, 2022
@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 19, 2022

  • contextmenu cut/move
  • add "paste" to breadcrumb 3-dots context-menu
  • make context-menu available via click in white space if time / efforts permits
  • nice to have: show keyboard shortcuts in context menu

paste here button should be dismissable, eg via a drop menu or split button with "X"

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 20, 2022

@lookacat for a first step I'd propose to not show the "Paste here" button next to the upload button but only have the "paste here" option in the context menu (MVP: breadcrumb 3-dots)

I would like to test if users really need the "Paste here" button nextx to "Upload" (my bet: yes) but lets test it.

would that procedure be ok for you?

@lookacat
Copy link
Contributor

ok

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 27, 2022

  • move should only be possible within Spaces (not possible cross storage space)
  • needs ui representation and proper dialog for copy @tbsbdr (prohibit if user cuts and pastes into different space like "cant move here, do you want to copy?" / behaviour like upload, shares & links get removed)

@kulmann kulmann added this to the 2.0.0 General Availability milestone Jul 27, 2022
@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 12, 2022

Proposals for the dialog.

What title is best?

I favour option 2 "Short question" as it's the shortest for "Only Title Reading Users" and as it is not a negative (defect-orientated) wording but more positive, solution orientated.

Negative:

image

Short question:

image

Long question:

image

The target for "Learn more" does not exist yet. Context-Helper could also do the job.

Any objections or additions against / to option 2 @lookacat @kulmann ?

@kulmann
Copy link
Member Author

kulmann commented Sep 13, 2022

thank you for thinking this through @tbsbdr !

I'm also in favour of option 2 (same reasoning, simple, focused on solution, reading the title gives the most important information).

For the description I'd like to suggest that we find a more generic text which works for single- and multi-file move attempts. Something like Moving files from one space to another is not possible. Do you want to copy instead?. What do you think?

And yes, context-helper would be good for Learn more.

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 13, 2022

yep, fine 👍 so lets go with:

image

@lookacat
Copy link
Contributor

will look into it

@kulmann
Copy link
Member Author

kulmann commented Sep 16, 2022

@lookacat thank you 😇

@tbsbdr could you provide a mockup for the contextual helper?

@tbsbdr
Copy link
Contributor

tbsbdr commented Sep 19, 2022

Contextual helper proposal:

  • singular/plural wording if one or many items are copied
  • dynamic insertion of the parent folder or Space (if it gets copied to a Space root)

figma link

Shares, links, and versions of this item are not copied. Tags will be copied. The copied item will be visible to everyone who can see “Budget-Folder 2023”.

Helper copy cross space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interaction:Needs-Concept Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Status: Done
4 participants