Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Left sidebar item is hard to read (because of wrong colors) #7190

Closed
tbsbdr opened this issue Jun 28, 2022 · 3 comments · Fixed by #7210 or #7270
Closed

Search: Left sidebar item is hard to read (because of wrong colors) #7190

tbsbdr opened this issue Jun 28, 2022 · 3 comments · Fixed by #7210 or #7270
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Jun 28, 2022

Steps to reproduce

  1. Login on https://ocis.ocis-web.latest.owncloud.works/
  2. create folder "New folder"
  3. search for "new" in all files
  4. Active item in left sidebar is hard to read (occurs in both, dark- and light mode)

screenie_Brave Browser_2022-06-28_at_14-22-44@2x
screenie_Brave Browser_2022-06-28_at_14-32-00@2x

Expected behaviour

No active left sidebar item on search result page.
If there was an active item for some reason, colors should be the same like in the initial status
screenie_Brave Browser_2022-06-28_at_14-28-37@2x
screenie_Brave Browser_2022-06-28_at_14-33-06@2x

Actual behaviour

  • Left sidebar item is hard to read (because of wrong colors)
@tbsbdr tbsbdr added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Jun 28, 2022
@kulmann
Copy link
Member

kulmann commented Jul 4, 2022

@janackermann mentioned in a chat that it's weird that Personal item is active on the search result page. Which is a correct observation.

@tbsbdr I'd propose to not have an active left sidebar nav item on the search result page. Another option could be to have a temporary Search result nav item which gets removed again when you leave the search result page.

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Jul 11, 2022

not have an active left sidebar nav item on the search result page

jep 👍 good idea.

@AlexAndBear
Copy link
Contributor

Follow up PR
#7270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
No open projects
Status: Done
3 participants