Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use disabled icon for "disabled" VPC firewall rules #2397

Closed
charliepark opened this issue Aug 26, 2024 · 3 comments · Fixed by #2399
Closed

Use disabled icon for "disabled" VPC firewall rules #2397

charliepark opened this issue Aug 26, 2024 · 3 comments · Fixed by #2399
Assignees
Milestone

Comments

@charliepark
Copy link
Contributor

charliepark commented Aug 26, 2024

Right now both "enabled" and "disabled" have a check icon. We should update the disabled one to … something else. CC @benjaminleonard

Screenshot 2024-08-26 at 3 17 29 PM
@benjaminleonard
Copy link
Contributor

See equivalent design for disks. If that isn't already using this icon it should also be:

image

@benjaminleonard benjaminleonard changed the title New icon for "disabled" state for VPC firewall rules Use disabled icon for "disabled" VPC firewall rules Aug 27, 2024
@charliepark charliepark added this to the Unscheduled milestone Aug 27, 2024
@charliepark
Copy link
Contributor Author

There are a number of other disk state options … are there specific icons we should be using for the other states? Or we could lean on <Success12Icon> and <Disabled12Icon> for attached/detached, and anything else gets <Info12Icon> for now?

@benjaminleonard
Copy link
Contributor

Good point, might be worthwhile adding some other roundels to account for all of them. Mind adding that as an issue and I'll get to mapping existing icons and creating any new ones if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants