Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-generator is producing duplicate models #260

Closed
david-crespo opened this issue Apr 15, 2021 · 2 comments · Fixed by #261
Closed

openapi-generator is producing duplicate models #260

david-crespo opened this issue Apr 15, 2021 · 2 comments · Fixed by #261

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Apr 15, 2021

Something is causing the generator to make two copies of some models that only differ in their names, like ApiRackView and ApiRackView1. This isn't a big problem in the short term because we can just use whatever it wants us to use, but it is weird and will eventually be a real problem.

Could be this, except our refs are all internal so maybe not: OpenAPITools/openapi-generator#2701

@david-crespo
Copy link
Collaborator Author

I think it's coming from the OpenAPI JSON we're getting from omicron. Issue here: oxidecomputer/omicron#64

@david-crespo david-crespo changed the title Figure out why openapi-generator is producing ApiProjectView1 openapi-generator is producing duplicate models Apr 16, 2021
@david-crespo
Copy link
Collaborator Author

Diagnosed here as coming from dropshot: oxidecomputer/dropshot#104

Will leave this issue open as a reminder to regenerate the API client once this gets fixed in Dropshot and that gets pulled into Omicron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant