Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server tunables should be configurable #23

Closed
davepacheco opened this issue Aug 6, 2020 · 1 comment
Closed

server tunables should be configurable #23

davepacheco opened this issue Aug 6, 2020 · 1 comment

Comments

@davepacheco
Copy link
Collaborator

Right now, Dropshot has three hardcoded "tunables":

config: ServerConfig {
/* We start aggressively to ensure test coverage. */
request_body_max_bytes: 1024,
page_max_nitems: NonZeroUsize::new(10000).unwrap(),
page_default_nitems: NonZeroUsize::new(100).unwrap(),
},

These should come from the ConfigDropshot struct, probably with default values.

@davepacheco
Copy link
Collaborator Author

Fixed by #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant