Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring http server parameters. #726

Open
luqmana opened this issue Jul 12, 2023 · 2 comments
Open

Allow configuring http server parameters. #726

luqmana opened this issue Jul 12, 2023 · 2 comments

Comments

@luqmana
Copy link
Contributor

luqmana commented Jul 12, 2023

While investigating oxidecomputer/omicron#3559 I wanted to change some some parameters like the HTTP/2 connection/stream window sizes but dropshot doesn't expose any way of doing so. The only way seems to be just cloning the repo, making the change, and use [patch] in Cargo.toml to pick it up in the downstream crate.

There are number of such options hyper's Builder exposes.

@rcgoodfellow
Copy link
Contributor

I've found myself in a similar situation. I need to set SO_REUSEADDR on the underlying TCP socket for a Dropshot server. It looks like being able to pass in a hyper Builder would allow that to happen.

@davepacheco
Copy link
Collaborator

Sounds good. There's no principled reason this isn't done. It just wasn't needed.

@jclulow and I discussed at some point creating a builder pattern that would allow people to provide ConfigDropshot, but wouldn't limit us to accepting things that way. It could also, for example, let you provide a hyper::Builder instead. This kind of thing could also allow us to avoid the breaking change from #676, though I wouldn't block a release on doing that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants