Serialize page token with MessagePack instead of as JSON string #924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept showing how easy this is to change. Would close #923 if we like it. Considerations:
PaginationVersion
? Currently, Nexus deploys involve shutting down all nodes, so the problem of old and new formats being used at the same time isn't likely to be a big problem, plus we'd have to add logic for handling both formatsdropshot/dropshot/src/pagination.rs
Lines 387 to 404 in 6b41086