Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nexus_client for /artifacts/{kind}/{name}/{version} #762

Closed
iliana opened this issue Mar 15, 2022 · 1 comment
Closed

Use nexus_client for /artifacts/{kind}/{name}/{version} #762

iliana opened this issue Mar 15, 2022 · 1 comment
Labels
cleanup Code cleanliness Sled Agent Related to the Per-Sled Configuration and Management Update System Replacing old bits with newer, cooler bits

Comments

@iliana
Copy link
Contributor

iliana commented Mar 15, 2022

omicron/sled-agent/src/updates.rs

Lines 43 to 59 in 6f6aba6

// ALSO TODO: This is, for the moment, using the endpoint directly
// instead of using the client method to work around issues in
// dropshot/progenitor for getting raw response bodies.
let response = nexus
.client()
.get(format!(
"{}/artifacts/{}/{}/{}",
nexus.baseurl(),
artifact.kind,
artifact.name,
artifact.version
))
.send()
.await
.map_err(Error::Response)?;
let contents =
response.bytes().await.map_err(|e| Error::Response(e))?;

Depends on pulling in changes from:

(From #717)
@iliana iliana added Sled Agent Related to the Per-Sled Configuration and Management Update System Replacing old bits with newer, cooler bits cleanup Code cleanliness labels Mar 15, 2022
@iliana
Copy link
Contributor Author

iliana commented Jul 26, 2022

Fixed in #1442.

@iliana iliana closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanliness Sled Agent Related to the Per-Sled Configuration and Management Update System Replacing old bits with newer, cooler bits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iliana