-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: Generate documentation #10
Conversation
Signed-off-by: Pamplemousse <[email protected]>
a0615eb
to
d50b9dc
Compare
Signed-off-by: Pamplemousse <[email protected]>
d50b9dc
to
a1673f2
Compare
looks good, nice work! it may be easier to seperate out the generation of different files into different directories, like is done in the include & dependency directories. makes things a bit easier to find :) |
'flake-prefetch.md', 'store-ls.md', 'add-file.md', 'flake-show.md', 'build.md', 'registry-remove.md', | ||
'print-dev-env.md', 'store-cat.md', 'log.md', join_paths('realisation', 'info.md'), | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please newline these file names to improve readability?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I generally agree, I don't for that file:
There is a substantial amount of source files that are declared, forcing to scroll quite a bit already to go to the interesting part (IMO, executable
declarations are more important than lines and lines of files).
@Pamplemousse i'm pretty sure the command to install needs to be sudo :) |
@Pamplemousse @Ericson2314 as NixOS#5094 has been merged, ill move the meson branch to the latest master then fix the build. should then be able to merge this too (provided no conflicts). |
@p01arst0rm I would merge this then rebase, now that all comments are addressed. |
Fix and test deleting when lower store references
I tried to convert the
doc/local.mk
as closely as possible;meson
'scommand
feature not being very flexible, I ended up writing scripts inscripts/manual
to be able to perform the needed actions.Also, I noted that some scripts were very similar, but I didn't try really hard to turn that into a unique parameterized script (it's not trivial);
highlight.js
manually NixOS/nix#5094but fix could always be added if the PR is not accepted upstream(merged!);meson install
failed because of compilation errors, so I couldn't check that.cc @Ericson2314