-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson improvements #9
Conversation
auto options are better for allowing autodetect, in addition to on and off.
This helps avoid merge conflicts, since git is line-oriented.
The whole point of the `files` function is that it remembers the current directory. Otherwise we could just use plain lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally, i think meson looks a lot neater when you dont newline the closers :')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im pretty sure files were added like this for a reason; albeit i cant remember that reason now! i think it was something to do with a bug in referencing file objects in different directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file looks excessively messy. Could you give it a do-over maybe? improve formatting n such
@Ericson2314 there is mixed usage of |
I strongly disagree:
|
LGTM: This seems to be a good improvement of the original PR 👍 |
not yet, still need to standardise the with/enable flags |
guess i could just do that myself :) |
Thanks! |
Thanks!! |
Add a GC test, fix hardlinking issue
See each commit for details. I took this from my old branches.
I think this is strictly better except for one issue: by default (with
stdenv.mkDerivation and Meson) we enable all optional features, and thus enable the s3 store. But the AWS pkg-config file is very bad in specifying
-fno-exceptionsand
std=c++11`, and this breaks the build.That means the build with AWS was always failing, but now with AWS is the effective default and thus the CI build will fail.
CC @Pamplemousse
N.B. Perhaps we should reframe from rebasing the PR while multiple people are working on it, and we are not sure if/when @edolstra is interested, as it was somewhat difficult to dredge up these changes.