-
-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2.x] Move popover instead of hide and show #819
Comments
I would not mind implementing this, but I don't think it's possible in SwiftUI without implementing custom views. A much simpler solution would probably be a complete disabling of popover show/hide animation, but I haven't found a way to do this in SwiftUI too. |
I noticed this too today. The API is pretty locked down. And various versions to implement it using |
I did some smaller improvements in f1f3ae7, maybe this approach can be used for moving popover too. |
I haven't found a way to utilise this for moving the popover, however I have experimented with having a "detached" popover without an arrow, that updates the content if the selection changes. I also added a shortcut for opening the popover ( Here is how it looks like: Screen.Recording.2024-08-04.at.12.15.49.movWhat do you think about this? Would it be worth while to add (some of) the following options:
|
I think it looks great overall, can you share a rough implementation how it works? I am not sure it makes sense to change this feature in 2.0, maybe postpone until 2.1 or consider a completely different approach to previews. I was thinking about potentially adding a slideout right sidebar with preview similar to https://cindori.com/developer/expandable-floating-panel but that's something for Maccy 3.x. |
The code can be found here: https://github.com/weisJ/Maccy/tree/custom/ There are some other changes in there too, but it should be possible to discern what is related to the popup. It’s also not very cleaned up currently. I like the idea of the slideout, though some caution needs to be taken to ensure it is always visible i.e if the window is too close to the right screen edge the slideout needs to be on the left etc. |
Let's park the idea for now, I'd like to focus on releasing 2.0 without any new big features, but make sure the app behaves well with increased storage size to 9999 (memory utilization, search, etc). If I can make it happen, it's already a big win and worth its own major release. |
Sure thing 👍🏻 getting out a first release for 2.0 really is the priority here. |
I strongly agree with these two suggestions and hope that they can be realized as soon as possible. |
Per https://www.reddit.com/r/macapps/comments/1fi6gw8/comment/lnmbpn8/
|
I have rebased https://github.com/weisJ/Maccy/tree/custom/ onto master. Maybe now that 2.0 has landed we can reopen the discussion for what the best approach to the info popup is. |
Before Submitting Your Feature Request
Problem
I think the hide and immediate reshow of the popover when the selection changes is a bit unwieldy. I think it would be beneficial to transition the position of the popover in the case where the selection moves to an adjacent item. Thought?
Solution
No response
The text was updated successfully, but these errors were encountered: