Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: New rpc_unix transport based on Unix socket #38

Merged
merged 2 commits into from
Feb 16, 2017

Conversation

ueno
Copy link
Member

@ueno ueno commented Jan 18, 2017

This is split from #15 and basically identical to NetworkManager@fbd884b. The only differences are:

@ueno ueno requested a review from lkundrak January 19, 2017 15:27
@lkundrak
Copy link
Collaborator

While I agree with the mailing list post that '/' would be better than '@', but I still maintain that 'unix:path=' would be better (as mentioned in the standalone server pull request). Hopefully I'm not bikeshedding too much.

The D-Bus transport name specifiers are already familiar to users and would make it easy to add new transports that may come useful in future, such as unix:tcp or unix:runtime (or even add unixexec: alias for | for no reason at all).

@ueno
Copy link
Member Author

ueno commented Jan 20, 2017

Yes, having a readable prefix for transport names sounds reasonable. However, for Unix domain sockets, IMO only "path" is relevant (in the D-Bus spec, "tmpdir" and "runtime" are shortcut for servers, and "abstract" doesn't really make sense these days; also "tcp" is not really Unix specific). So I have changed it from '/' to "unix=/".

Also added a standalone test case.

@ueno ueno mentioned this pull request Jan 25, 2017
@ueno
Copy link
Member Author

ueno commented Jan 25, 2017

I ended up with "unix:path=" for consistency with DBUS_*_ADDRESS.

@ueno ueno force-pushed the wip/dueno/rpc-unix-socket branch 2 times, most recently from cc892f0 to ad7c245 Compare January 26, 2017 12:58
@ueno ueno added this to the future milestone Feb 2, 2017
ueno and others added 2 commits February 16, 2017 16:27
This adds p11_path_{encode,decode}(), following the escaping rule
described in:
https://dbus.freedesktop.org/doc/dbus-specification.html#addresses

Although they are merely a wrapper around p11_url_{decode,encode}(),
having dedicated functions hides the implementation details.
@ueno ueno merged commit 89fa381 into p11-glue:master Feb 16, 2017
@ueno ueno deleted the wip/dueno/rpc-unix-socket branch March 1, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants