Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing check for destroy_with; inconsistent with VirtualCollection's implementation #14

Open
thecontstruct opened this issue Jan 6, 2016 · 1 comment
Open

Missing check for destroy_with; inconsistent with VirtualCollection's implementation #14

thecontstruct opened this issue Jan 6, 2016 · 1 comment

Comments

@thecontstruct
Copy link

In GroupedCollection you only check for close_with even though it also listens for destroy events. This is inconsistent with VirtualCollection where you explicitly checks for both close_with and destroy_with and attach the appropriate listeners.
@p3drosola
Copy link
Owner

Thanks for catching it @thecontstruct. Want to make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p3drosola @thecontstruct