Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show button for filter settings on filtered post #33

Closed
nikclayton opened this issue Sep 12, 2023 · 1 comment
Closed

Show button for filter settings on filtered post #33

nikclayton opened this issue Sep 12, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nikclayton
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If a post has been filtered with "warn" there's a placeholder to show the post. This would be a good spot to include a button to edit that specific filter. The user might want to easily change the filter from warn to hide, for example.

Describe the solution you'd like

Either:

  1. An additional UI control on the placeholder, sufficiently far from the control that shows the post. When tapped it opens the filter settings page for the filter that triggered the warn for this status.

Or:

  1. An additional UI control on the placeholder, sufficiently far from the control that shows the post. When tapped it changes the filter that triggered the warn to a "hide" filter, and refreshes the display.

A complication with both of these approaches is that a single status might be matched by multiple filters. If that happens tapping the control should (maybe) open a menu listing the filters that matched, and allow the user to choose which one they want to change.

@nikclayton nikclayton added enhancement New feature or request good first issue Good for newcomers labels Sep 12, 2023
@nikclayton
Copy link
Contributor Author

Implemented in #819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

1 participant