fix: merge pact duplicates with diff desc/same prov state #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOU54F
commented
Jun 10, 2024
| // seems to be a problem setting the version, which defaults to v3 | ||
| // pactffi_new_message will accept a MessageHandle over the FFI barrier, but rust typing wont allow us | ||
| // to pass a PactHandle along with pactffi_with_specification | ||
| #[ignore = "require ability to set pact specification version in pactffi_new_message_pact"] |
There was a problem hiding this comment.
i probably need to pull this out into a new issue. pact-new uses a new_message_interaction which is replicated in the test above.
fix: merge message / sync pacts with no provider state
|
See pact-stub-server for an example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: merge message / sync pacts with no provider state
fixes #389